Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove margin-right on Loader in Block header #7315

Closed
2 of 3 tasks
ashetland opened this issue Jul 12, 2023 · 1 comment
Closed
2 of 3 tasks

Remove margin-right on Loader in Block header #7315

ashetland opened this issue Jul 12, 2023 · 1 comment
Assignees
@Elijbet
Labels
1 - assigned Issues that are assigned to a sprint and a team member. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library

Comments

@ashetland
Copy link
Contributor

Check existing issues

Description

In issue #6485 and PR #7239, the inline Loader was repositioned in Block's header. Too improve spacing, we'd like to remove the 8px margin-right that comes from Loader when it is set to inline.

Acceptance Criteria

Loader's margin-right reduced to 0px.

Relevant Info

cc @Elijbet

image

Which Component

Block

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (design)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 12, 2023
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. labels Jul 12, 2023
@Elijbet Elijbet self-assigned this Aug 18, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 28, 2024
@ashetland
Copy link
Contributor Author

Closing in favor of #7492.

@ashetland ashetland mentioned this issue Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Elijbet Elijbet

Labels
1 - assigned Issues that are assigned to a sprint and a team member. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@geospatialem @Elijbet @ashetland