Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon] Some recently added, special case icons not available in dist #6272

Closed
macandcheese opened this issue Jan 12, 2023 · 6 comments
Closed

[Icon] Some recently added, special case icons not available in dist #6272

macandcheese opened this issue Jan 12, 2023 · 6 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 2 Small fix or update, may require updates to tests.
Milestone
2023 January Prio...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jan 12, 2023 •
edited
Loading

Actual Behavior

Some recently added icons with special cases (from what I gather, names that have -f or start with a number: https://github.com/Esri/calcite-components/blob/efd08f11effbd109a334e36ce817658966422a69/src/components/icon/utils.ts#L64) are not available in when used with CC / CC React. In a local development environment, some do seem to work, but still not all are available (or are available but being incorrectly referenced somehow)

Screen Shot 2023-01-11 at 4 00 07 PM

Screen Shot 2023-01-11 at 3 57 22 PM

Screen Shot 2023-01-11 at 4 05 21 PM

Expected Behavior

All icons are available for use, within calcite-icon component and when passed as property value to other components, like combobox-item

Codepen: https://codepen.io/mac_and_cheese/pen/zYLwPoR?editors=1000
CodeSandbox: https://codesandbox.io/s/funny-jackson-tb8ufc?file=/src/App.js

Reproduction Sample

Above

Reproduction Steps

Visit either reproduction link, see missing icons.

Reproduction Version

Latest

Relevant Info

No response

Regression?

No response

Impact

No response

Esri team

Calcite (design)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 12, 2023
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Jan 12, 2023
@jcfranco
Copy link
Member

I think this partly a calcite-ui-icon issue. This is what I'm noticing:

  1. bookmark-f – the convention for filled icons has been <iconName>-<size>(-f), but for this one it's <iconName>(-f)-<size>. This is causing the utility to not build the correct file name.
  2. 1-2x, 8x, 1-4x, and similar ones – these have no matching data path files (SVGs start with 1-2x, JSON starts with aZ16).
  3. satellite-2-f – these should be in the latest calcite-components release

This was referenced Jan 26, 2023
Closed
Closed
@jcfranco
Copy link
Member

I've created issues for items 1 and 2.

@jcfranco
Copy link
Member

jcfranco commented Feb 2, 2023

Correction, 2 is a valid issue. The icon util needs to be updated to properly handle the #-#x/#x cases.

@jcfranco jcfranco added the estimate - 2 Small fix or update, may require updates to tests. label Feb 2, 2023
@jcfranco
Copy link
Member

jcfranco commented Feb 3, 2023

I'm taking this one for our current milestone to sync up with the incoming UI icon update. cc @geospatialem

@jcfranco jcfranco self-assigned this Feb 3, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 3, 2023
@jcfranco jcfranco mentioned this issue Feb 4, 2023
Merged
jcfranco added a commit that referenced this issue Feb 6, 2023
@jcfranco
fix(icon): fix icon normalization to handle x-times-named icons (#6422)
f3dd490 
**Related Issue:** #6272

## Summary

This fixes an issue where our icon names weren't mapped correctly to
some newly added icons (e.g., `1x`, `1-8x`).
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 6, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 8, 2023
@geospatialem
Copy link
Member

Verified in 1.0.4 and React 1.0.1

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. estimate - 2 Small fix or update, may require updates to tests.
Projects
None yet
Milestone
2023 January Priorities Patch - Bugs ...
Development

No branches or pull requests
3 participants
@jcfranco @macandcheese @geospatialem