Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Missing icons in JS files output #252

Closed
jcfranco opened this issue Jan 26, 2023 · 2 comments
Closed

Missing icons in JS files output #252

jcfranco opened this issue Jan 26, 2023 · 2 comments
Assignees

Comments

@jcfranco
Copy link
Member

This came up in Esri/calcite-design-system#6272 (comment)

  1. 1-2x, 8x, 1-4x, and similar ones – these have no matching data path files (SVGs start with 1-2x, JSON starts with aZ16).

cc @SkyeSeitz

@SkyeSeitz SkyeSeitz self-assigned this Jan 30, 2023
@SkyeSeitz
Copy link
Contributor

Thanks, @jcfranco. I see the js output gives svgs titled first with integer an i prefix so there are data paths to the icons mentioned but they are listed as:

i12x16.js
i14x16.js
i18x16.js
i1X16.js

etc.

Do you recommend any changes to the metadata or svg names for this issue or can we re-route these as is?

@jcfranco
Copy link
Member Author

jcfranco commented Feb 2, 2023

Oh, I forgot that icons that start w/ numbers get prefixed. 😅 This is a non-issue for the icons then as the icons you listed above are available (e.g., i12x16.js). The icon utility in calcite-components needs to be updated to handle the #-#x/#x cases.

Thanks for looking into this!

@jcfranco jcfranco closed this as completed Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants