Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown contents should not be dependent on the parent element #431

Closed
dhrumil83 opened this issue Apr 2, 2020 · 1 comment
Closed

Dropdown contents should not be dependent on the parent element #431

dhrumil83 opened this issue Apr 2, 2020 · 1 comment
Assignees
@jcfranco
Labels
enhancement Issues tied to a new feature or request.

Comments

@dhrumil83
Copy link

Enhancement to this fix: #396
Codepen: https://codepen.io/dhrumil83/pen/poJBbEW

Can end up with 2 scrollbars when parent element to the dropdown has a height specified.

image

Behavior should be like the regular select, where the scrolling is independent of the parent element.
image

Potential fix can be to open the dropdown contents in a popover/popper?
Short term fix can be to let the client specify the max allowed height.
@macandcheese macandcheese added component-dropdown enhancement Issues tied to a new feature or request. labels Apr 2, 2020
@jcfranco jcfranco self-assigned this Apr 3, 2020
@jcfranco jcfranco added this to the 🔨 v1-beta.22 milestone Apr 3, 2020
@jcfranco jcfranco mentioned this issue Apr 3, 2020
Merged
@jcfranco
Copy link
Member

jcfranco commented Apr 3, 2020

I submitted a PR to allow users to specify the max items to show before we show the scroller.

jcfranco added a commit that referenced this issue Apr 3, 2020
@jcfranco
feat(dropdown): specify max items to display before scrolling is enab…
623f8e7 
…led (#435)

#431
@macandcheese macandcheese removed this from the 🔨 v1-beta.22 milestone Apr 3, 2020
@paulcpederson paulcpederson mentioned this issue Oct 29, 2020
Closed
@jcfranco jcfranco mentioned this issue Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfranco jcfranco

Labels
enhancement Issues tied to a new feature or request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcfranco @macandcheese @dhrumil83