Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Prop to constrain height of combobox menus #1198

Closed
paulcpederson opened this issue Oct 29, 2020 · 2 comments
Closed

Enhancement: Prop to constrain height of combobox menus #1198

paulcpederson opened this issue Oct 29, 2020 · 2 comments
Labels
0 - new New issues that need assignment. enhancement Issues tied to a new feature or request.

Comments

@paulcpederson
Copy link
Member

paulcpederson commented Oct 29, 2020

Description

Currently the max-height of an open dropdown is 90vh and the combobox list is 100vh. This is generally not desirable as the chances that the item is at the very top of the screen and you'd like it to take up the full screen is slim to none.

We should provide a max-items prop so that devs can style these UI's in ways that make sense for their application.

Acceptance Criteria

<calcite-combobox max-items="5"></calcite-combobox> will show five items and the rest will be available via scroll.

Relevant Info

#396 : issue about large scrolling dropboxes
#431 : issue about max-height in dropboxes
#195 : popover going off-screen

Which Component

calcite-combobox

Example Use Case

Combobox at the bottom of a form:

Screen Shot 2020-10-28 at 5 16 14 PM

Height is full screen height, so entire dialog will scroll to cover it:

Screen Shot 2020-10-28 at 5 16 51 PM

Then there is even more because it's not constrained to the container, but rather the screen:

Screen Shot 2020-10-28 at 5 16 58 PM

@paulcpederson paulcpederson added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. labels Oct 29, 2020
@paulcpederson
Copy link
Member Author

Dropbox has this already! Just noticed, so really just making combobox work like this.

@paulcpederson paulcpederson changed the title Enhancement: Prop to constrain height of dropdown/combobox menus Enhancement: Prop to constrain height of combobox menus Oct 29, 2020
@paulcpederson
Copy link
Member Author

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. enhancement Issues tied to a new feature or request.
Projects
None yet
Development

No branches or pull requests

1 participant