Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: calcite-list is missing setFocus() #3275

Closed
2 tasks
AdelheidF opened this issue Oct 15, 2021 · 4 comments
Closed
2 tasks

Bug: calcite-list is missing setFocus() #3275

AdelheidF opened this issue Oct 15, 2021 · 4 comments
Assignees
@benelan
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Milestone
Sprint 10/11 – 10/22

Comments

@AdelheidF
Copy link

calcite-value-list and calcite-pick-list both have a setFocus method. calcite-list doesn't even though I can tab through each list-item and focus it this way.

Actual Behavior

no setFocus method

Expected Behavior

add setFocus method

Reproduction Steps and Sample

https://codepen.io/afreitag/pen/zYdrogo
Sample:

Relevant Info

Version: @esri/[email protected]

  • CDN
  • NPM package
@AdelheidF AdelheidF added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 15, 2021
driskull added a commit that referenced this issue Oct 15, 2021
@driskull
feat(list, list-item): Add setFocus method. #3275
70530c8
@driskull driskull mentioned this issue Oct 15, 2021
Closed
driskull added a commit that referenced this issue Oct 18, 2021
@driskull
feat(list, list-item): Add setFocus method. #3275
c4edbc5
driskull added a commit that referenced this issue Oct 18, 2021
@driskull @dependabot
@jcfranco @anveshmekala @y0n4 @benelan @github-actions @eriklharper
fix(link): Setting the href property after init should update renderi…
eaab123 
…ng (#3222)

* fix(link): Setting the href property after init should update rendering. #2153

* connectedCallback back

* build(deps): bump @storybook/addon-docs from 6.3.10 to 6.3.11 (#3221)

Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs) from 6.3.10 to 6.3.11.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.11/addons/docs)

---
updated-dependencies:
- dependency-name: "@storybook/addon-docs"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump eslint-plugin-unicorn from 37.0.0 to 37.0.1 (#3220)

Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) from 37.0.0 to 37.0.1.
- [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases)
- [Commits](sindresorhus/eslint-plugin-unicorn@v37.0.0...v37.0.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-unicorn
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @stencil/sass from 1.4.1 to 1.5.2 (#3219)

Bumps [@stencil/sass](https://github.com/ionic-team/stencil-sass) from 1.4.1 to 1.5.2.
- [Release notes](https://github.com/ionic-team/stencil-sass/releases)
- [Commits](ionic-team/stencil-sass@v1.4.1...v1.5.2)

---
updated-dependencies:
- dependency-name: "@stencil/sass"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @storybook/cli from 6.3.10 to 6.3.11 (#3217)

Bumps [@storybook/cli](https://github.com/storybookjs/storybook/tree/HEAD/lib/cli) from 6.3.10 to 6.3.11.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.11/lib/cli)

---
updated-dependencies:
- dependency-name: "@storybook/cli"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build: add license preamble for distributable code (#2537)

#947

* build(deps): bump @storybook/addon-a11y from 6.3.10 to 6.3.11 (#3218)

Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y) from 6.3.10 to 6.3.11.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.11/addons/a11y)

---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Driscoll <[email protected]>

* feat(block): add loading status to block header (#3158)

* feat(block): add loading status to block header

* add e2e to verify loading class

* feedback changes

* re-trigger codeQL job

* feedback syntax changes

* 1.0.0-next.287 [skip ci]

* fix(combox-item): adjust height of the item to be consistent respective to its scale size (#3144) (#3197)

* fix(combox-item): adjust height of the item to be consistent respective to its scale size (#3144)

* fix(combobox-item): keep the container styling relative to the scale size

* fix(combobox-item): review pr comment suggestion for styling

* refactor(filter): avoid stateful regexp used for filtering

* 1.0.0-next.288 [skip ci]

* build(deps): bump storybook from 6.3.10 to 6.3.11 (#3233)

Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/lib/cli) from 6.3.10 to 6.3.11.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.11/lib/cli)

---
updated-dependencies:
- dependency-name: storybook
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @storybook/html from 6.3.10 to 6.3.11 (#3232)

Bumps [@storybook/html](https://github.com/storybookjs/storybook/tree/HEAD/app/html) from 6.3.10 to 6.3.11.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.11/app/html)

---
updated-dependencies:
- dependency-name: "@storybook/html"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(dropdown): close on outside click when disable-close-on-select is true #3136 (#3227)

* fix(dropdown): remove preventDefault and stopPropagation on click event (#3231)

* fix(dropdown): close on outside click when disable-close-on-select is true #3136

* fix(dropdown): remove preventDefault on click event. #1709

* 1.0.0-next.289 [skip ci]

* fix(combobox): add chevron icon at end of input regardless of selecti… (#3143)

* fix(combobox): add chevron icon at end of input regardless of selection mode (#3055)

* fix(combobox): align the chevron icon to be centered vertically on multiple chips select mode (#3055)

* fix(action-bar): get up-to-date master changes

* feat(combobox): add additional story for multiple with preselected inputs

* fix(combobox): make all the combobox height size consistent scale

* 1.0.0-next.290 [skip ci]

* docs(input-time-picker): value is always 24-hour format (#3245)

* build(deps): bump @storybook/cli from 6.3.11 to 6.3.12 (#3251)

Bumps [@storybook/cli](https://github.com/storybookjs/storybook/tree/HEAD/lib/cli) from 6.3.11 to 6.3.12.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.12/lib/cli)

---
updated-dependencies:
- dependency-name: "@storybook/cli"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump eslint from 8.0.0 to 8.0.1 (#3252)

Bumps [eslint](https://github.com/eslint/eslint) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v8.0.0...v8.0.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @storybook/addon-docs from 6.3.11 to 6.3.12 (#3254)

Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs) from 6.3.11 to 6.3.12.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.12/addons/docs)

---
updated-dependencies:
- dependency-name: "@storybook/addon-docs"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* test(input): Skip unstable test. #3257 (#3258)

* build(deps): bump eslint-plugin-jest from 25.0.5 to 25.2.0 (#3256)

Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 25.0.5 to 25.2.0.
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v25.0.5...v25.2.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-jest
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @storybook/html from 6.3.11 to 6.3.12 (#3255)

Bumps [@storybook/html](https://github.com/storybookjs/storybook/tree/HEAD/app/html) from 6.3.11 to 6.3.12.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.12/app/html)

---
updated-dependencies:
- dependency-name: "@storybook/html"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump storybook from 6.3.11 to 6.3.12 (#3253)

Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/lib/cli) from 6.3.11 to 6.3.12.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.12/lib/cli)

---
updated-dependencies:
- dependency-name: storybook
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump ts-jest from 27.0.5 to 27.0.6 (#3259)

Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 27.0.5 to 27.0.6.
- [Release notes](https://github.com/kulshekhar/ts-jest/releases)
- [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md)
- [Commits](kulshekhar/ts-jest@v27.0.5...v27.0.6)

---
updated-dependencies:
- dependency-name: ts-jest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @storybook/addon-a11y from 6.3.11 to 6.3.12 (#3260)

Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y) from 6.3.11 to 6.3.12.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.12/addons/a11y)

---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: update component READMEs (#3264)

Co-authored-by: jcfranco <[email protected]>

* fix(action)!: deprecating outline appearance (#3263)

* docs(conventions): fixing grammar errors (#3261)

* fix(action): fixing RTL display bugs by replacing getElementDir and RTL CSS classes with CSS logical properties (#3140)

* refactor: Convert SASS division to multiplication where possible. #3249 (#3268)

* refactor: Convert SASS division to multiplication where possible. #3249

* use calc

* fix negate

* feat(list, list-item): Add setFocus method. #3275

* fix selector

* fix test

* refactor: change onLabelClick to be a class method (#3165)

#3161

* chore(hooks): add pre-push hook to confirm admin-pushes from master (#3273)

* feat(output-targets): add custom-elements output target (#3224)

* chore(action): allow ember-twiddle repro samples (#3244)

* fix(block-section): enable word wrap (#3156)

* fix(block-section): enable text wrap

* revert changes to demo html

* refactor to support safari browser

* readability

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: JC Franco <[email protected]>
Co-authored-by: Anveshreddy mekala <[email protected]>
Co-authored-by: Travis CI User <[email protected]>
Co-authored-by: Yona N <[email protected]>
Co-authored-by: Ben Elan <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: jcfranco <[email protected]>
Co-authored-by: Erik Harper <[email protected]>
@driskull
Copy link
Member

@benelan can we triage this for the current milestone?

@benelan benelan added this to the Sprint 10/11 – 10/22 milestone Oct 18, 2021
@benelan
Copy link
Member

benelan commented Oct 18, 2021

yessir @driskull

@jcfranco jcfranco removed the needs triage Planning workflow - pending design/dev review. label Oct 18, 2021
@driskull driskull added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 19, 2021
@driskull driskull mentioned this issue Oct 19, 2021
Closed
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 19, 2021
@github-actions github-actions bot assigned benelan and unassigned driskull Oct 19, 2021
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@benelan
Copy link
Member

benelan commented Oct 21, 2021

verified on next

@benelan benelan closed this as completed Oct 21, 2021
@benelan benelan added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
Sprint 10/11 – 10/22
Development

No branches or pull requests
4 participants
@jcfranco @driskull @benelan @AdelheidF