Bug: calcite-link not linked if href defined later

[nwhittaker]

Actual Behavior

If a <calcite-link> element's href attribute is not immediately known (i.e. the element is disabled while waiting on resolving the link through a URL shortening service like Bitly), setting the href value later has no effect.

Expected Behavior

After setting the link's href attribute, clicking the link works as expected.

Reproduction Steps or Sample

<calcite-link id="link" href="">link</calcite-link>
<button onclick="document.getElementById('link').href = 'https://www.esri.com';">Set href</button>

1. Run the above snippet.
2. Wait ~1sec, then click the Set href button.
3. Click the link text.

Relevant Info

Version: @esri/[email protected]

[driskull]

@jcfranco @benelan calcite-input and calcite-button most likely have similar issues with their 'type'.

Also things like this:

• https://github.com/Esri/calcite-components/blob/master/src/components/calcite-combobox-item/calcite-combobox-item.tsx#L94
• https://github.com/Esri/calcite-components/blob/master/src/components/calcite-dropdown-group/calcite-dropdown-group.tsx#L69
• https://github.com/Esri/calcite-components/blob/master/src/components/calcite-inline-editable/calcite-inline-editable.tsx#L85-L90
• https://github.com/Esri/calcite-components/blob/master/src/components/calcite-slider/calcite-slider.tsx#L125-L126
• https://github.com/Esri/calcite-components/blob/master/src/components/calcite-accordion-item/calcite-accordion-item.tsx#L92

These are all called once when the component is initialized so these states may get out of sync if the component is moved or if content is inserted into it at a later time.

We may need to do an audit of lifecycle methods like componentWillLoad and make sure that any props that are being setup are also updated via watchers. We also might need to bring it up a meeting to make sure all of our state is reactive.

[driskull]

And for things like this: https://github.com/Esri/calcite-components/blob/master/src/components/calcite-accordion-item/calcite-accordion-item.tsx#L86

We may want to use a mutationObserver instead since if the parent of this element adds the selection-mode at a later time, the child won't know about it.

We should probably phase out the getElementProp utility.

[github-actions]

Installed and assigned for verification.

[benelan]

verified on next