forked from OffchainLabs/nitro-testnode
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smoke test for nitro testnode #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sneh1999
requested review from
ImJeremyHe,
nomaxg,
alysiahuggins,
zacshowa and
sveitser
as code owners
August 15, 2024 14:19
Sneh1999
commented
Aug 15, 2024
.github/workflows/ci.yml
Outdated
- name: Startup Nitro testnode | ||
run: ${{ github.workspace }}/.github/workflows/testnode.bash | ||
|
||
# This is currently broken as L3 node support needs to be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its being fixed here: #41
sveitser
reviewed
Aug 16, 2024
I think we can do this a bit simpler fashion, will push an update to this PR in a bit |
ImJeremyHe
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #186
EspressoSystems/nitro-espresso-integration#186
This PR:
This PR introduces a new bash script to run smoke test against the latest code in our nitro integration. It runs this script in the CI pipeline and this workflow will run every day once.
This PR does not:
Key places to review: