Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke test for nitro testnode #44

Merged
merged 19 commits into from
Aug 16, 2024
Merged

Smoke test for nitro testnode #44

merged 19 commits into from
Aug 16, 2024

Conversation

Sneh1999
Copy link

@Sneh1999 Sneh1999 commented Aug 15, 2024

Closes #186

EspressoSystems/nitro-espresso-integration#186

This PR:

This PR introduces a new bash script to run smoke test against the latest code in our nitro integration. It runs this script in the CI pipeline and this workflow will run every day once.

This PR does not:

Key places to review:

@Sneh1999 Sneh1999 marked this pull request as ready for review August 15, 2024 14:19
@Sneh1999 Sneh1999 marked this pull request as draft August 15, 2024 14:20
- name: Startup Nitro testnode
run: ${{ github.workspace }}/.github/workflows/testnode.bash

# This is currently broken as L3 node support needs to be fixed
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its being fixed here: #41

@Sneh1999 Sneh1999 marked this pull request as ready for review August 15, 2024 20:37
smoke-test-node.bash Outdated Show resolved Hide resolved
@sveitser
Copy link
Collaborator

I think we can do this a bit simpler fashion, will push an update to this PR in a bit

@sveitser sveitser merged commit 792eaed into integration Aug 16, 2024
2 of 3 checks passed
@sveitser sveitser deleted the smoke-test-script branch August 16, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants