Fix the l3node #41
Merged
Fix the l3node #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImJeremyHe
requested review from
nomaxg,
alysiahuggins,
zacshowa,
Sneh1999 and
sveitser
as code owners
sveitser
reviewed
Aug 19, 2024
|
I think we should add a CI workflow to run the smoke test on the L3. It can be based on the current smoke test. Otherwise if we break the L3 support via espresso-dev-node or by breaking the bash script we won't know. |
sveitser
reviewed
Aug 20, 2024
smoke-test.bash
Outdated
| echo "Smoke test succeeded" | ||
| docker compose down | ||
|
|
||
| # Testing the l3node |
There was a problem hiding this comment.
@ImJeremyHe Lets make it a separate github action workflow run and also test that the staker is working. Either set up a matrix to execute the script with 2 configurations or duplicate the workflow and modify it for the L3. I think both are fine.
- Remove docker caching that would only work on persitent runner
- Check staker confirms nodes
This reverts commit 670ae9e.
sveitser
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Fix the L3 node
Currently, when enabling L3 node, we will run an L2 node without enabling the espresso mode.
Also add a simple test for l3 node in smoke-test
How to test this PR
Run the
./smoke-test.bash