Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scoping out txn fetching #4

Closed
wants to merge 4 commits into from
Closed

scoping out txn fetching #4

wants to merge 4 commits into from

Conversation

ImJeremyHe
Copy link
Member

No description provided.

@ImJeremyHe ImJeremyHe changed the base branch from master to integration October 25, 2023 05:29
ImJeremyHe
ImJeremyHe commented Oct 25, 2023
View reviewed changes
execution/gethexec/sequencer.go
@@ -710,7 +723,116 @@ func (s *Sequencer) precheckNonces(queueItems []txQueueItem) []txQueueItem {
return outputQueueItems
}

func (s *Sequencer) createBlockEspresso(ctx context.Context) (returnValue bool) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move these code to the arbnode to let every validator forward txs and build block. arb sequencer is a centralized thing

Copy link
Member Author

@ImJeremyHe ImJeremyHe Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it is not easy to update arb sequencer to let every one run it because arbitrum now is not permissionless.

@ImJeremyHe
Copy link
Member Author

ImJeremyHe commented Oct 25, 2023 •
edited
Loading

I think this is a more easier and cleaner way to integrate with it, but I'm not sure if this is enough for us.

@nomaxg
Copy link

nomaxg commented Oct 25, 2023

I think this is a more easier and cleaner way to integrate with it, but I'm not sure if this is enough for us.

I think that right now, the sequencer is encapsulated in the Execution, so we would need to some how remove/modify that component if we take that approach. We could consider implementing our own ExecutionSequencer, but that might be a lot more overhead than just modifying their existing sequencer.

@ImJeremyHe
Copy link
Member Author

In the docker-compose.yaml in the test node, we can see every role in this system acts differently just because of their own config files.

The latest commit I submitted clearly shows the differences between the validator and sequencer. Since every node has full same functions, it is both okay for us to update the existing sequencer or validator. But maybe we can add our integration as a new module in nitro it may much easier for us to keep sync with it.

@nomaxg nomaxg closed this Nov 2, 2023
@sveitser
Copy link

sveitser commented Nov 2, 2023

New PR: #10

@ImJeremyHe ImJeremyHe deleted the fetch-transaction branch December 4, 2023 08:43
nomaxg pushed a commit that referenced this pull request Jul 22, 2024
@renlulu @nomaxg
feat: support eigenda
45fda10 
refactor: clean up logs and functions (#4)

fix: log error (#8)

fix: staker with self-validation (#9)

doc: clean comment (#13)

* refactor: clean doc

* doc: add todo for replay

* doc: add alt license header

* doc: change some comment for replay
zacshowa pushed a commit that referenced this pull request Nov 26, 2024
@PlasmaPower
Merge pull request #4 from OffchainLabs/gas-estimate-no-padding
f88a36c 
Document that gasEstimateL1Component doesn't pad its estimate
zacshowa pushed a commit that referenced this pull request Nov 26, 2024
@rachel-bousfield
Merge pull request #4 from OffchainLabs/hostio-remove-extra
2284688 
Remove blockhash and difficulty from unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alysiahuggins alysiahuggins Awaiting requested review from alysiahuggins alysiahuggins will be requested when the pull request is marked ready for review alysiahuggins is a code owner

@zacshowa zacshowa Awaiting requested review from zacshowa zacshowa will be requested when the pull request is marked ready for review zacshowa is a code owner

@Sneh1999 Sneh1999 Awaiting requested review from Sneh1999 Sneh1999 will be requested when the pull request is marked ready for review Sneh1999 is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser will be requested when the pull request is marked ready for review sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer will be requested when the pull request is marked ready for review jbearer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ImJeremyHe @nomaxg @sveitser