-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add justification to batches, progress on validation pipeline #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm getting this failure locally for
|
This makes the `ExampleBroadcastMessage_broadcastfeedmessage` test pass without having to change the expected output.
arbitrator/jit/src/wavmio.rs
Outdated
let message = comm_map.get(&msg_num).unwrap_or(&[0; 32]); | ||
|
||
if out_ptr + 32 > sp.memory_size() { | ||
error!("memory bounds exceeded in {name}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macro error!
is used only for once, I think it is better to expand it here and remove the macro.
@@ -101,6 +109,38 @@ pub fn read_delayed_inbox_message(mut env: WasmEnvMut, sp: u32) -> MaybeEscape { | |||
inbox_message_impl(&sp, inbox, "wavmio.readDelayedInboxMessage") | |||
} | |||
|
|||
// Reads a hotshot commitment | |||
fn read_hotshot_commitment_impl( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please help me understand this a bit better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, essentially what we are doing is validating that espresso batches (which currently map 1-to-1 to arbitrum batches) correspond to a valid hotshot commitment. This function implements a host-io function that reads a hotshot commitment, so that the wasm layer can pass a commitment to ProduceBlock
Add stylus programSize and programMemoryFootprint precompiles
This PR introduces:
Future work:
Depends on:
EspressoSystems/geth-arbitrum#2
To test (for backwards compatibility):
./test-node.bash --dev --init ./test-node.bash script send-l2 --to address_0x673C9b46952080D3bf1B8d689C7BBC590a8755Cb --ethamount 5 --l2url # spin up validation nodes docker compose up validation_node docker compose up validator