Move tee address #392
Merged
Move tee address #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the TEE verifier contract address to the transaction streamer, configurable via the batch posters config.
zacshowa
requested review from
ImJeremyHe,
alysiahuggins,
Sneh1999,
sveitser and
jbearer
as code owners
Koanf cannot parse a common.Address by default, so we should use a string when taking in this config option.
Sneh1999
reviewed
Dec 17, 2024
| var err error | ||
| espresso, _ := b.streamer.isEspressoMode() | ||
| if !espresso { | ||
| if b.streamer.lightClientReader != nil && b.streamer.espressoClient != nil { |
There was a problem hiding this comment.
Well this check only happens when the batch poster is started to prevent it from posting any data until the chain config was updated. Given we don't populate this at runtime anymore, the check doesn't matter
Sneh1999
approved these changes
Dec 17, 2024
Sneh1999
reviewed
Dec 17, 2024
| @@ -670,21 +671,6 @@ func (s *TransactionStreamer) AddFakeInitMessage() error { | |||
| }}) | |||
| } | |||
|
|
|||
| func (s *TransactionStreamer) isEspressoMode() (bool, error) { | |||
| config, err := s.exec.GetArbOSConfigAtHeight(0) // Pass 0 to get the ArbOS config at current block height. | |||
There was a problem hiding this comment.
Actually can we remove the GetArbOSConfigAtHeight function? What do you think?
There was a problem hiding this comment.
I was planning to do that in a separate PR with an issue created here
ImJeremyHe
pushed a commit
that referenced
this pull request
Dec 18, 2024
* move espressoTeeVerifierAddr to transaction streamer This commit moves the TEE verifier contract address to the transaction streamer, configurable via the batch posters config. * Fix tests and transaction_streamer * use a string for tee verifier address Koanf cannot parse a common.Address by default, so we should use a string when taking in this config option. * fix compilation * fix e2e test * Fix config parsing * Fix lint and run formatter * Remove outdated test (cherry picked from commit 30689d6)
Sneh1999
added a commit
that referenced
this pull request
Dec 18, 2024
* Move tee address (#392) * move espressoTeeVerifierAddr to transaction streamer This commit moves the TEE verifier contract address to the transaction streamer, configurable via the batch posters config. * Fix tests and transaction_streamer * use a string for tee verifier address Koanf cannot parse a common.Address by default, so we should use a string when taking in this config option. * fix compilation * fix e2e test * Fix config parsing * Fix lint and run formatter * Remove outdated test (cherry picked from commit 30689d6) * Add attestation quote to Espresso payload (#385) * Add attestation quote to Espresso payload * cleanup code * fix lint * add position * fix verify namespace proof bug * Increase hotshot transaction limit * build hotshot payload and add unitests for it * Verify merkle proof first * Rename * push minor fixes --------- Co-authored-by: ImJeremyHe <[email protected]> (cherry picked from commit 47e6010) --------- Co-authored-by: Zach Showalter <[email protected]> Co-authored-by: Sneh Koul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #387
This PR:
Moves the espresso tee verifier address to reside in the batch poster and transaction streamer as opposed to the chain config
This PR does not:
Clean up the unused arbos config fetching code, tests, or update the test-node /migration test to reflect these changes.
Key places to review:
arbnode/batch_poster.goarbnode/transaction_streamer.goHow to test this PR:
run the E2E test
Things tested
A modified version of the migration test passes locally.