Add attestation quote to Espresso payload #385
Conversation
Sneh1999
force-pushed
the
add-tee-proof-to-espresso-payload
branch
from
504da89 to
a7c11d2
Compare
Sneh1999
requested review from
ImJeremyHe,
alysiahuggins,
zacshowa,
sveitser and
jbearer
as code owners
There was a problem hiding this comment.
Looks good. Just some comments.
This PR sends all the messages to espresso, which helps nodes derive L2 state from Espresso. My question is why users not to derive state from seqeuncer inbox, but from Espresso. If this scenario exists, that also means we can't activate the escape hatch, which may skip submitting messages to espresso.
Does finality node need changes according to these changes? I didn't see its modifications in this PR
I think your concern is valid, escape hatch might not work well with the finality node. We can change the finality node later and think about this later as well. But yes, we should keep this in mind when we are making changes to the finality node |
ImJeremyHe
force-pushed
the
add-tee-proof-to-espresso-payload
branch
2 times, most recently
from
e0af17e to
4bf08d7
Compare
ImJeremyHe
force-pushed
the
add-tee-proof-to-espresso-payload
branch
from
4bf08d7 to
16c22a2
Compare
ImJeremyHe
force-pushed
the
add-tee-proof-to-espresso-payload
branch
from
fc094b1 to
dd3f7ef
Compare
ImJeremyHe
force-pushed
the
add-tee-proof-to-espresso-payload
branch
from
dd3f7ef to
139ac64
Compare
* Add attestation quote to Espresso payload * cleanup code * fix lint * add position * fix verify namespace proof bug * Increase hotshot transaction limit * build hotshot payload and add unitests for it * Verify merkle proof first * Rename * push minor fixes --------- Co-authored-by: ImJeremyHe <[email protected]> (cherry picked from commit 47e6010)
* Move tee address (#392) * move espressoTeeVerifierAddr to transaction streamer This commit moves the TEE verifier contract address to the transaction streamer, configurable via the batch posters config. * Fix tests and transaction_streamer * use a string for tee verifier address Koanf cannot parse a common.Address by default, so we should use a string when taking in this config option. * fix compilation * fix e2e test * Fix config parsing * Fix lint and run formatter * Remove outdated test (cherry picked from commit 30689d6) * Add attestation quote to Espresso payload (#385) * Add attestation quote to Espresso payload * cleanup code * fix lint * add position * fix verify namespace proof bug * Increase hotshot transaction limit * build hotshot payload and add unitests for it * Verify merkle proof first * Rename * push minor fixes --------- Co-authored-by: ImJeremyHe <[email protected]> (cherry picked from commit 47e6010) --------- Co-authored-by: Zach Showalter <[email protected]> Co-authored-by: Sneh Koul <[email protected]>
This PR:
This PR fixes this issue
Key places to review:
Please review this PR carefully as its a very important PR