This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Delete the Storage type and file
#18
Merged
+3
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References issue: #2788
What is this task and why do we need to work on it?
We have a lot of old dead code because conensus used be completely state driven, i.e. blocks were state updates, it used to be very explicitly one view at a time, not event driven. One of these artifacts exists as the
Storagetrait, found here.As a result of the need to support storing DA, VID diseperals, and later work by sequencer (tracking: #2621), we need to deprecate and remove this type from the code and modernize its name. This issue is preliminarily responsible for only the removal of this type from the code.
What does this PR do?
HotShot-Typesby deleting the entire file and all associations.