[CX_CLEANUP] - Deprecate and remove Storage trait and usages

[jparr721]

What is this task and why do we need to work on it?

We have a lot of old dead code because conensus used be completely state driven, i.e. blocks were state updates, it used to be very explicitly one view at a time, not event driven. One of these artifacts exists as the Storage trait, found here.

As a result of the need to support storing DA, VID diseperals, and later work by sequencer (tracking: #2621), we need to deprecate and remove this type from the code and modernize its name. This issue is preliminarily responsible for only the removal of this type from the code.

What work will need to be done to complete this task?

• Remove the type from HotShot-Types
• Remove MemoryStorage
• Remove AtomicStorage

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

Remove all instances of the Storage trait and derivative implementations. All existing tests should still pass without needing to change anything in a substantial way.

Branch work will be merged to (if not the default branch)

No response