remove builder event types #97
Conversation
imabdulbasit
force-pushed
the
ab/remove-builder-event-types
branch
from
60fcfa9 to
d202e8f
Compare
src/events_source.rs
Outdated
|
|
||
| // required for sending startup info | ||
| known_nodes_with_stake: Vec<PeerConfig<Types::SignatureKey>>, | ||
| non_staked_node_count: usize, | ||
| filter: Option<EventFilterSet<Types>>, |
There was a problem hiding this comment.
I think this should not be a property of the EventsStreamer but of the connection, so different clients can have different filters. E.g. it could be a parameter of get_event_stream, which would then apply a filter(...) before returning the stream.
There was a problem hiding this comment.
hmm my initial idea was to broadcast only events needed but this is better.
| #[async_trait] | ||
| pub trait EventsSource<Types> | ||
| where | ||
| Types: NodeType, | ||
| { | ||
| type EventStream: Stream<Item = Arc<Event<Types>>> + Unpin + Send + 'static; | ||
| async fn get_event_stream(&self) -> Self::EventStream; | ||
|
|
||
| async fn subscribe_events(&self) -> BoxStream<'static, Arc<Event<Types>>> { |
There was a problem hiding this comment.
looked unnecessary
|
Hi @nyospe @imabdulbasit , Earlier we defined BuilderEvents to suppress the unnecessary stuff embedded in HotShot events which builder don't care about as it used to affect builder performance. For e.g . we removed something from Decide event here: #53. I am not sure whether that went away with this change. |
This PR: