Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prune decide #53

Merged
merged 1 commit into from
Apr 25, 2024
Merged

prune decide #53

merged 1 commit into from
Apr 25, 2024

Conversation

move47
Copy link
Contributor

@move47 move47 commented Apr 25, 2024 •
edited
Loading

The builder just needs latest_leaf_decide numbers, thus we can get rid of other attached data otherwise it occupies a decent space onto the channel.

@move47 move47 requested a review from nyospe April 25, 2024 20:53
nyospe
nyospe approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@nyospe nyospe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. We should get data on txn size to determine whether the refactoring for DA Proposal (and BlockPayload::builder_commitment) is worth it.

@move47 move47 merged commit 414397e into main Apr 25, 2024
4 checks passed
@move47 move47 mentioned this pull request Apr 25, 2024
Closed
@move47 move47 linked an issue Apr 25, 2024 that may be closed by this pull request
Prune Decide #55
Closed
@move47 move47 mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyospe nyospe nyospe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prune Decide
2 participants
@move47 @nyospe