Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge flake.nix #43

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Merge flake.nix #43

merged 1 commit into from
Mar 8, 2022

Conversation

DieracDelta
Copy link
Contributor

This PR removes the libp2p-networking flake.(nix|lock) and moves the useful pieces from this flake into the rootflake.nix. Notably:

  • Nix shell to compile static binaries with musl
  • Nix shell with performance tooling (grcov, flamegraph, nightly cargo)
  • Programmatic generation of check and package attributes for all members of the workspace
  • Overrides for protobuf (needed on aarch64-darwin and perhaps linux)

@VictorKoenders
Copy link
Contributor

I get this error running nix-shell in the phaselock folder:

error: a 'aarch64-linux' with features {} is required to build '/nix/store/ni2xlnpykcfhx7y48y7y30p30hd3682z-camino-1.0.4.tar.gz.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, kvm, nixos-test}

@DieracDelta
Copy link
Contributor Author

This "should" work (it works for me on darwin). Turns out // was forcing all derivations to be evaluated which requires target-triple specific features b/c of IFD. The fix is to manually hard code in the checks/packages directly. No idea why dontRecurseIntoAttrs doesn't work here...

VictorKoenders
VictorKoenders previously approved these changes Mar 8, 2022
@DieracDelta
Copy link
Contributor Author

It's probably fine to ignore the CI complaints since these are fixed in #35

@VictorKoenders VictorKoenders merged commit 5825f0c into main Mar 8, 2022
@DieracDelta DieracDelta deleted the jr/merge_flakes branch March 31, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants