Replace identity_mappings.json with cli variables #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmccarty
pushed a commit
that referenced
this pull request
Mar 7, 2022
chore(deps): bump libp2p from 0.42.2 to 0.43.0
DieracDelta
force-pushed
the
jr/remove_json_config
branch
2 times, most recently
from
edeaafb to
081c9f9
Compare
VictorKoenders
suggested changes
Mar 8, 2022
DieracDelta
force-pushed
the
jr/remove_json_config
branch
from
081c9f9 to
1866107
Compare
VictorKoenders
previously approved these changes
Mar 8, 2022
DieracDelta
force-pushed
the
jr/remove_json_config
branch
from
1866107 to
0753b69
Compare
|
Oh look new CVE just dropped, right when your PR was ready to be merged https://rustsec.org/advisories/RUSTSEC-2022-0013 |
VictorKoenders
approved these changes
Mar 8, 2022
Merged
VictorKoenders
added a commit
that referenced
this pull request
Mar 8, 2022
Replace identity_mappings.json with cli variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a subset of the items in this issue. Notably:
Conductornode repeatedly broadcasts its peers. The reason for this message is preventConductornodes from being pruned.$IP:$PORTstaticshell to a separate shell denotedstaticShell, s.t.nix developallows for compiling to work on macos and linux. To access the shell, runnix develop .#staticShell.Note this runs on our aws cluster. The next step (in a separate PR) will be to include a dockerfile for usage on fargate.