Refactor into workspace #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nmccarty
force-pushed
the
nm/workspace-refacto
branch
from
6ca5890 to
63fdf55
Compare
nmccarty
force-pushed
the
nm/workspace-refacto
branch
from
80f5e5a to
0d0e3ee
Compare
Nearly completly migrate over the data and traits modules to phaselock-types. This includes: - The hash types and assocaited macro generation - The Stage enum - The Quorum certificate types - The State and BlockContents traits - The Message module and associated types - The PubKey and PrivKey types - The NetworkingImplementation trait - The Storage trait - The NodeImplementation trait - The Event struct and EventType enum This required changing some pub(crate)s over to pub. No breaking changes have been made in phaselock, as the modules have been modified to rexport the relevant types. This change will allow an implementation of one of the core phaselock traits, such as a NetworkingImplmentation, to live in a seperate crate from phaselock proper, while still allowing phaselock to depend upon it without creating a circular dependency. Closes #25
Update the nix flake to be workspace aware, and update the lockfiles in the process
nmccarty
force-pushed
the
nm/workspace-refacto
branch
from
af8e756 to
c8e5088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR refactors phaselock into a workspace consisting of two crates,
phaselockandphaselock-types. This is to allow the core phaselock types and traits to be in their own crate, so that implementations can be in their own crates, and still be used inphaselockproper without creating a circular dependency.implements #25