Refactor into workspace #25
Assignees
Comments
nmccarty
added a commit
that referenced
this issue
Feb 14, 2022
Completly migrate over the data module to phaselock-types. This includes: - The hash types and assocaited macro generation - The Stage enum - The Quorum certificate types - The State and BlockContents traits This required changing some pub(crate)s over to pub. No breaking changes have been made in phaselock, as the modules have been modified to rexport the relevant types. Refs #25
Merged
Merged
nmccarty
added a commit
that referenced
this issue
Feb 14, 2022
Completly migrate over the data module to phaselock-types. This includes: - The hash types and assocaited macro generation - The Stage enum - The Quorum certificate types - The State and BlockContents traits - The Message module and associated types - The PubKey and PrivKey types This required changing some pub(crate)s over to pub. No breaking changes have been made in phaselock, as the modules have been modified to rexport the relevant types. Refs #25
nmccarty
added a commit
that referenced
this issue
Feb 15, 2022
Completly migrate over the data module to phaselock-types. This includes: - The hash types and assocaited macro generation - The Stage enum - The Quorum certificate types - The State and BlockContents traits - The Message module and associated types - The PubKey and PrivKey types This required changing some pub(crate)s over to pub. No breaking changes have been made in phaselock, as the modules have been modified to rexport the relevant types. Refs #25
nmccarty
added a commit
that referenced
this issue
Feb 15, 2022
Nearly completly migrate over the data and traits modules to phaselock-types. This includes: - The hash types and assocaited macro generation - The Stage enum - The Quorum certificate types - The State and BlockContents traits - The Message module and associated types - The PubKey and PrivKey types - The NetworkingImplementation trait - The Storage trait - The NodeImplementation trait - The Event struct and EventType enum This required changing some pub(crate)s over to pub. No breaking changes have been made in phaselock, as the modules have been modified to rexport the relevant types. This change will allow an implementation of one of the core phaselock traits, such as a NetworkingImplmentation, to live in a seperate crate from phaselock proper, while still allowing phaselock to depend upon it without creating a circular dependency. Closes #25
nmccarty
pushed a commit
that referenced
this issue
Mar 4, 2022
chore(deps): bump rand from 0.8.4 to 0.8.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Phaselock need's to be broken up into at least 2 crates, one containing types and traits, and the other containing business logic, to enable having the networking layer be its own crate without creating a circular dependency.
The text was updated successfully, but these errors were encountered: