Indexes Payload store by view number #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenkeyao
previously approved these changes
Jan 23, 2024
| @@ -55,7 +55,7 @@ pub struct Consensus<TYPES: NodeType> { | |||
| /// | |||
| /// Contains the block payload commitment and encoded transactions for every leaf in | |||
| /// `saved_leaves` if that payload is available. | |||
| pub saved_payloads: PayloadStore, | |||
| pub saved_payloads: BTreeMap<TYPES::Time, Vec<u8>>, | |||
There was a problem hiding this comment.
Same as the other PR. Let's update the comment.
shenkeyao
previously approved these changes
Jan 23, 2024
jbearer
reviewed
Jan 23, 2024
jbearer
previously approved these changes
Jan 24, 2024
jbearer
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2448
This PR:
Stops using our custom
PayloadStoreand just uses BTreeMap. This means we may have duplicate Payloads in the store, but the store will remain quite small so should not be an issue. We usesplit_offfor GCing the map just like the state map. This gets rid of all the payloads prior to decide, should be a straight forward way to GC.This PR does not:
This is not the PR which fixes this for the release branch. Review that one first
Key places to review:
Is garbage collection and intialization correct? Am I always indexing with the correct view number