Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement block header #1937

Merged
merged 18 commits into from
Oct 31, 2023
Merged

Implement block header #1937

merged 18 commits into from
Oct 31, 2023

Conversation

shenkeyao
Copy link
Member

@shenkeyao shenkeyao commented Oct 24, 2023 •
edited
Loading

  • Adds block header trait and struct impl.
  • Replaces BlockType with BlockPayload.
  • Replaces block commitment and height in the proposal with the block header.
  • Sends the block commitment rather than the full block to the quorum.
  • Updates consensus task to handle block commitment rather than block payload.

Closes #1566. Closes #1796.

jbearer
jbearer reviewed Oct 24, 2023
View reviewed changes
crates/hotshot/src/demo.rs Outdated Show resolved Hide resolved
crates/hotshot/src/tasks/mod.rs Outdated Show resolved Hide resolved
crates/task-impls/src/consensus.rs Outdated Show resolved Hide resolved
crates/task-impls/src/consensus.rs Outdated Show resolved Hide resolved
crates/types/src/certificate.rs Outdated Show resolved Hide resolved
crates/types/src/traits/block_contents.rs Outdated Show resolved Hide resolved
elliedavidson
elliedavidson reviewed Oct 25, 2023
View reviewed changes
crates/task-impls/src/consensus.rs Outdated Show resolved Hide resolved
crates/task-impls/src/consensus.rs Outdated Show resolved Hide resolved
crates/task-impls/src/consensus.rs Outdated Show resolved Hide resolved
crates/testing/tests/network_task.rs Outdated Show resolved Hide resolved
crates/types/src/block_impl.rs Show resolved Hide resolved
jbearer
jbearer reviewed Oct 27, 2023
View reviewed changes
crates/task-impls/src/consensus.rs Outdated Show resolved Hide resolved
crates/task-impls/src/consensus.rs Outdated Show resolved Hide resolved
crates/task-impls/src/consensus.rs Outdated Show resolved Hide resolved
jbearer
jbearer reviewed Oct 30, 2023
View reviewed changes
crates/task-impls/src/consensus.rs Outdated Show resolved Hide resolved
crates/task-impls/src/consensus.rs Show resolved Hide resolved
crates/types/src/data.rs Outdated Show resolved Hide resolved
crates/types/src/data.rs Outdated Show resolved Hide resolved
crates/types/src/data.rs Outdated Show resolved Hide resolved
jbearer
jbearer approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@jbearer jbearer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@shenkeyao shenkeyao merged commit e78b628 into develop Oct 31, 2023
7 checks passed
@shenkeyao shenkeyao deleted the keyao/block-header branch October 31, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliedavidson elliedavidson elliedavidson left review comments

@jbearer jbearer jbearer approved these changes

@bfish713 bfish713 Awaiting requested review from bfish713 bfish713 is a code owner

@dailinsubjam dailinsubjam Awaiting requested review from dailinsubjam

@rob-maron rob-maron Awaiting requested review from rob-maron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove height from proposal validation logic Define a concept of a block header
3 participants
@shenkeyao @jbearer @elliedavidson