Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a concept of a block header #1566

Closed
Tracked by #1671
jbearer opened this issue Aug 15, 2023 · 5 comments · Fixed by #1937
Closed
Tracked by #1671

Define a concept of a block header #1566

jbearer opened this issue Aug 15, 2023 · 5 comments · Fixed by #1937

Comments

@jbearer
Copy link
Member

jbearer commented Aug 15, 2023

In the sequencer, we have introduced the concept of an app-specific header, which clients can download if they want authenticated metadata like timestamps but not the whole block payload. This concept could be enshrined in HotShot itself, which would allow us to implement endpoints that deal with headers in the generic query service, instead of specifically for the sequencer node. This would also allow us to include the block number in the header and header commitment, which would simplify a lot of interfaces. We currently can't do this because the application doesn't know the block number when it is asked to create the next block.

@shenkeyao
Copy link
Member

shenkeyao commented Sep 6, 2023

Requirements

  • Header constructor takes the previous leaf (includes the previous header) and payload commitment (provided by DA leader task)
  • Header must commit to the payload using a VID commitment
    • Trait function to get the payload commitment from a header
  • Header includes fees, latest Ethereum block, etc.
  • Only header is included in proposals; payload is sent to DA committee only

@jbearer
Copy link
Member Author

jbearer commented Sep 6, 2023

Header must be retrievable by the VID commitment

I missed this in the meeting, I'm not sure exactly what this means @shenkeyao @elliedavidson

@elliedavidson
Copy link
Member

I'm unsure as well

@shenkeyao
Copy link
Member

Header must be retrievable by the VID commitment

I missed this in the meeting, I'm not sure exactly what this means @shenkeyao @elliedavidson

@jbearer This looks like a duplication of the previous point, “Header must commit to the payload using a VID commitment.”

I think we could remove this requirement from the list, but @elliedavidson could I get the link to the meeting recording? Then I’ll double check this from the recording.

@shenkeyao
Copy link
Member

Header must be retrievable by the VID commitment

I missed this in the meeting, I'm not sure exactly what this means @shenkeyao @elliedavidson

@jbearer This looks like a duplication of the previous point, “Header must commit to the payload using a VID commitment.”

I think we could remove this requirement from the list, but @elliedavidson could I get the link to the meeting recording? Then I’ll double check this from the recording.

I've checked the recording and "retrievable by the VID commitment" wasn't mentioned. I've removed it from the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants