Sishan/basic metrics #1852
Merged
Sishan/basic metrics #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Shot into sishan/basic_metrics
…nnected_peers Sishan/Revoke metric for tracking the number of peers.
…tworking_metrics basic metrics completed for networking metrics
…nc_last_block sishan/synced most recent block height
7 tasks
dailinsubjam
requested review from
bfish713,
DieracDelta,
shenkeyao,
elliedavidson and
rob-maron
elliedavidson
requested changes
Oct 9, 2023
| @@ -1075,6 +1096,8 @@ where | |||
| "We received a timeout event in the consensus task for view {}!", | |||
| *view | |||
| ); | |||
| let consensus = self.consensus.read().await; | |||
There was a problem hiding this comment.
Where do we reset this metric? I think we should reset it once we have a view that succeeds.
There was a problem hiding this comment.
This is for resetting the consensus metric number_of_timeouts, and will not be used for any other place. The whole consensus thing is wrapped in an Arc, therefore as long as we know which one to change it should be okay (like here we simply want to get self.consensus).
shenkeyao
reviewed
Oct 9, 2023
elliedavidson
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revokes metrics for
The main parts for review are:
crates/types/src/consensus.rs,crates/task-impls/src/consensus.rs, andcrates/hotshot/src/traits/networking.rs.