Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] - Block Height #2131

Closed
jbearer opened this issue Nov 29, 2023 · 1 comment
Closed

[metrics] - Block Height #2131

jbearer opened this issue Nov 29, 2023 · 1 comment
Assignees
Labels

Comments

@jbearer
Copy link
Member

jbearer commented Nov 29, 2023

What is this task and why do we need to work on it?

#1564

We provide block height in its own endpoint in the query service, but Blockdaemon has requested that we also include it in the Prometheus metrics, which I think makes it easier for them to implement monitoring.

What work will need to be done to complete this task?

  • Add a new counter to the consensus metrics
  • Increment the counter at each decide

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

  • A new block_height counter metrics exists, and always reflects the number of decided leaves
@dailinsubjam
Copy link
Contributor

Done in #1852.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants