Updated to .Net and made main command readers use async /await #169
Conversation
|
Oh, .NET9 is not supported, any problem adding it ? |
|
Let's stay on .NET 8 LTS pls |
|
Done, back on 8 |
|
Why the async commands? |
|
There are "scalability" problems as pointed out by Brent O, i would suspect using threads that block rather than async could contribute... I have a few other ideas on how to enhance the product too if you want to mail:[email protected] to discuss |
|
Do you have a link to the Brent O statement? |
|
@daveTechLed Have you done any benchmarking? |
|
I don’t have any complaints, works fine for me. Not sure what that reference is to.---Tiny glass keyboardTypos flowing like riversAs winter snow thawsOn Nov 29, 2024, at 9:37 AM, Erik Ejlskov Jensen ***@***.***> wrote:
Do you have a link to the Brent O statement?
@BrentOzar ?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
https://www.brentozar.com/archive/2019/04/free-sql-server-load-testing-tools/ " it’s not unusual to hit ASYNC_NETWORK_IO waits with SQLQueryStress when it’s unable to keep up with digesting the results" My educated guess is that moving to Async/Await will help. |
Nope, but i could try to set something up. |
|
Oh sure, that’s true about async_network_io, but that’s not a SQLQueryStress problem - that just means we’re shoving a lot of results into it.Changing SQLQueryStress to async won’t fix that - it still has to pull the results back. ---Tiny glass keyboardTypos flowing like riversAs winter snow thawsOn Nov 29, 2024, at 11:01 AM, daveTechLed ***@***.***> wrote:
I don’t have any complaints, works fine for me. Not sure what that reference is to.---Tiny glass keyboardTypos flowing like riversAs winter snow thawsOn Nov 29, 2024, at 9:37 AM, Erik Ejlskov Jensen @.> wrote: Do you have a link to the Brent O statement? @BrentOzar ? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>
https://www.brentozar.com/archive/2019/04/free-sql-server-load-testing-tools/
" it’s not unusual to hit ASYNC_NETWORK_IO waits with SQLQueryStress when it’s unable to keep up with digesting the results"
My educated guess is that moving to Async/Await will help.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
If you have suggestions, feel free to open new issues here and we can discuss in the open. Are you the maintainer of TSQLSmells code analyzers btw? (I ported them to .NET 6+)
Actually, SqlClient has severe performance issues reading large columns async, so it could become worse. See dotnet/SqlClient#593 |
|
Closed now, a quick example is in my repo, i've added a Gannt chart to represent executions.. Next will be calling the SQL statements setting CONTEXT_INFO. I'll grab various extended events from the server and then should be able to correlate the two so that when you hover over the execution the relevant XE's are shown |
Ah, i did not know about the large column issue.. sound like a fix is on the way though! Yes, I am / was the maintainer of TSQLSmells. Using VS as a release vehicle got the better of me though and got a bit crazy finding the right folder for the plugin for the various combinations of VS/SQL that was needed. Do you know if that has changed ? Every once in a while i consider using SSMS/VS for it but never seems an amazing amount of community interest when i raise it. FWIW : Ive made some mods in my branch above, an XE trace is created and then result captured. The Gannt chart in the bottom pane shows the execution times of each, and selecting an execution will show the XE events (hardcoded for the moment,could use a predefined) captured for that executions CONTEXT_INFO. All very alpha, but even in this state , useful i think :) |
|
No, no changes for VS but changes for .NET - you can use NuGet packages now. See my blog posts https://erikej.github.io/dacfx/codeanalysis/sqlserver/2024/04/02/dacfx-codeanalysis.html Could you share a screenshot of your chart? |
|
Sure ... here you go |
|
@BrentOzar Thoughts? ^^ Maybe slightly out of scope? |
|
@daveTechLed Adam has given his sign of approval - looking forward to a PR! |
No description provided.