Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampling: Sort indices with argsort kernel #239

Closed
wants to merge 1 commit into from
Closed

Sampling: Sort indices with argsort kernel #239

wants to merge 1 commit into from

Conversation

EricLBuehler
Copy link
Owner

@EricLBuehler EricLBuehler commented Apr 28, 2024 •
edited
Loading

Refs #232.

@EricLBuehler EricLBuehler linked an issue Apr 28, 2024 that may be closed by this pull request
Accelerate topk, topp sampling with argsort #232
Closed
@github-actions GitHub Actions
Copy link

Code Metrics Report 
  ───────────────────────────────────────────────────────────────────────────────
Language                 Files     Lines   Blanks  Comments     Code Complexity
───────────────────────────────────────────────────────────────────────────────
Rust                        70     23366     1552       508    21306       1284
───────────────────────────────────────────────────────────────────────────────
Total                       70     23366     1552       508    21306       1284
───────────────────────────────────────────────────────────────────────────────
Estimated Cost to Develop 70,690
Estimated Schedule Effort 11.816600 months
Estimated People Required 5.042498
───────────────────────────────────────────────────────────────────────────────
Processed 769217 bytes, 0.769 megabytes (SI)
───────────────────────────────────────────────────────────────────────────────

@EricLBuehler
Copy link
Owner Author

Causes large performance regression due to dual-synchronization.

@EricLBuehler EricLBuehler deleted the argsort_sampling branch April 28, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accelerate topk, topp sampling with argsort
1 participant
@EricLBuehler