Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accelerate topk, topp sampling with argsort #232

Closed
EricLBuehler opened this issue Apr 28, 2024 · 0 comments
Closed

Accelerate topk, topp sampling with argsort #232

EricLBuehler opened this issue Apr 28, 2024 · 0 comments
Labels
optimization

Comments

@EricLBuehler
Copy link
Owner

Argsort was just added to Candle (huggingface/candle#2132). Using an argsort kernel will accelerate the current CPU sorting part of topk or topp sampling, which takes a lot of time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sampling: Sort indices with argsort kernel EricLBuehler/mistral.rs
1 participant
@EricLBuehler