Skip to content

Commit

Permalink
Fixed Enumerated Conversation Suggestion Bug
Browse files Browse the repository at this point in the history
The bug occurred when listing subtopics. Also updated version number for imminent 2.1.1 release
  • Loading branch information
EricEve committed Sep 4, 2024
1 parent fe94541 commit a9c263d
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 12 deletions.
17 changes: 8 additions & 9 deletions actor.t
Original file line number Diff line number Diff line change
Expand Up @@ -1645,13 +1645,7 @@ modify Actor
*/
else if(tag not in (nil, 'all'))
lst = lst.intersect(valToList(convKeyTab[tag]));

/*
* Initialize the suggestion enumerator to clear out any leftover information from
* previous suggestion listings.
*/
suggestionEnumerator.initialize();


/*
* Use the suggestedTopicLister to show a list of Suggested Topics
* from the resulting list (lst).
Expand Down Expand Up @@ -7199,7 +7193,12 @@ suggestedTopicLister: object
}

show(lst, explicit = true)
{
{
/*
* Initialize the suggestion enumerator to clear out any leftover information from
* previous suggestion listings.
*/
suggestionEnumerator.initialize();
/*
* first exclude all items that don't have a name property, since
* there won't be anything to show.
Expand Down Expand Up @@ -7352,7 +7351,7 @@ suggestedTopicLister: object
{
/*
* If the current topic entry wants to include a sayPrefix,
* displat the sayPrefix. In practice this only applies to
* display the sayPrefix. In practice this only applies to
* SayTopics which may or may not want to introduce the name of a
* suggestion with 'say'.
*/
Expand Down
5 changes: 4 additions & 1 deletion docs/manual/changelog.htm
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ <h1>Change Log</h1>
<li><a href="#v0.2">Version 0.2</a></li>
</ul>

<h2><a name='v2-1-1'>Version 2.1.1</a> (tbd) </h2>
<h2><a name='v2-1-1'>Version 2.1.1</a> (04-Sep-2024) </h2>
<p>Fixed an issue with the way the location of a MultiLoc is calculated when one of the locations of the MultiLoc is in a room visible from another room in the same SenseRegion and the actor is in that other room (previously this could result in the actor not being able to view the MultiLoc, even though it should have been possible).</p>
<hr>
<p>The message explaining how to toggle the enumeration and/or hyperlinking of conversation topic suggestions has been tidied up into a more compressed form. It has also been changed to use the notification style tag rather than the parser style tag, since this is more consistent with how these style tags are meant to be used. The same change has been applied to a couple of other messages, such as those for turning on and off the notification of score changes.</p>
Expand All @@ -63,6 +63,9 @@ <h2><a name='v2-1-1'>Version 2.1.1</a> (tbd) </h2>
<hr>
<p>Fixed bug in the <b>objDetached</b> precondition (brackets were missing from a foreach loop).</p>
<hr>
<p>Fixed bug with enumeration of subtopics when enumeration of topic suggestions is active.</p>
<hr>


<h2><a name='v2-1'>Version 2.1</a> (03-July-2024) </h2>
<p>The behaviour of the <b>MoveTo</b> action has be modified (with a small RISK OF AFFECTING EXISTING CODE). The previous behaviour could often prove counter-intuitive or confusing. The main purpose of the MOVE TO command was and is to allow notional relocation of objects to a particular vicinity within a room, e.g. so that the player might need to use the command MOVE CHAIR TO BOOKCASE before standing on the chair to reach the top shelf of the bookcase, in which case the chair's <span class='code'>movedTo</span> property becomes set to the bookcase (for game code to check). But this probably doesn't feel like the expected behaviour when the indirect object of a MOVE TO command is a container or surface. e.g. MOVE PEN TO BOX or MOVE BOOK TO SHELF, so now when the indirect object of a MOVE TO command is a container, the command will be converted to PUT IN and when it's a surface the command will be converted to PUT ON.</p>
Expand Down
2 changes: 1 addition & 1 deletion modid.t
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ moduleAdv3Lite: ModuleID
byline = 'by Eric Eve'
htmlByline = 'by <a href="mailto:[email protected]">'
+ 'Eric Eve</a>'
version = '2.1.0.0.4 - 2024-08-19 13:35'
version = '2.1.1'
/*
* We use a listing order of 50 so that, if all of the other credits
Expand Down
2 changes: 1 addition & 1 deletion readme.htm
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</head>
<body>
<div class="main">
<h1>ADV3LITE VERSION 2.1</h1>
<h1>ADV3LITE VERSION 2.1.1</h1>

<p>Thank you for your interest in adv3Lite, an alternative library for use with the TADS 3 Interactive Fiction authoring system.</p>

Expand Down

0 comments on commit a9c263d

Please sign in to comment.