Crud #2
Crud #2
Conversation
| ### CRUD API | ||
| To create a new user in the database: | ||
| send POST request to domain/api/users with the user name in the body of the request with the name field (name: username) |
There was a problem hiding this comment.
Did this require anything in the body, or does it only need the name in the header?
| const fakeUser = (userName) => { | ||
| let randomNumber = Math.floor(Math.random() * 100 + 1); | ||
| return { | ||
| name: userName, | ||
| imageUrl: `https://hackreactoramazonfrontendcapstone.s3-us-west-2.amazonaws.com/${randomNumber}.jpeg` | ||
| } | ||
| } |
There was a problem hiding this comment.
Might be worth moving this out of index at some point.
A lot of places use a fairly blank default image for new users - having something like that mike make sense if a picture has be attached. Something like that could be stored locally and could improve time down the line.
| To delete all reviews for a property listing: | ||
| send DELETE request to domain/api/rentals/id where id is the number id of the listing |
There was a problem hiding this comment.
Like the focused use of README - didn't try to rewrite, just stayed on point with putting in what had to be put in.
| let userName = req.body.name; | ||
| User.insertMany(fakeUser(userName)) | ||
| .then(data => console.log(`Inserted ${data} into database`)) | ||
| .then(res.sendStatus(200)) | ||
| .catch(err => console.log(`ERROR createing user: ${err}`)); | ||
| }) |
There was a problem hiding this comment.
Clear, simple, and easy to follow.
Curious why insertMany over a single method like .save?
Recommend dropping the console log for success once you're confident this works. Could send a success message to client?
Also recommend changing the error entry to console.error
Nice use of backticks and string templates!
Pull request for CRUD API. Readme contains current info on how/what each route does