Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config by attribute is not working: ex. Restrict by dateMin #2881

Closed
3 tasks done
numediaweb opened this issue Dec 1, 2023 · 2 comments · Fixed by #2887
Closed
3 tasks done

Config by attribute is not working: ex. Restrict by dateMin #2881

numediaweb opened this issue Dec 1, 2023 · 2 comments · Fixed by #2887

Comments

@numediaweb
Copy link

Prerequisites

Describe the issue

I have checked the docs but couldn't find any mention of providing "inline" config options via the input element data attributes.
I tried every combination to name the attributes but none of them work:

 <input id="datetimepicker1Input" type="text" class="form-control"
        data-td-target="#datetimepicker1" 
        data-td-restrictions-min-date="12/01/2023 00:00 A" 
        data-td-restrictions-mindate= "12/01/2023 00:00 A"
        data-td-restrictions-minDate="12/01/2023 00:00 A" 
>

Am I missing some parts of the docs?

Any help would be appreciated :)

StackBlitz fork

https://stackblitz.com/edit/tempus-dominus-v6-repl-zrh1cx?file=index.html,example.js

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Chrome

What version of are you using? You can find this information from the sample StackBlitz.

v6

What your browser's locale? You can find this information from the sample StackBlitz.

en-US

@numediaweb numediaweb added State: Triage Tickets that need to be triaged. Type: Bug labels Dec 1, 2023
@Eonasdan Eonasdan added Area: TypeScript and removed State: Triage Tickets that need to be triaged. labels Dec 19, 2023
@Eonasdan
Copy link
Owner

Hi. I'll push out a fix for this soon. You will want to use data-td-restrictions_mindate. JS converts the data- attributes to CamelCase and strips the - marks. Should go out this week

@Eonasdan Eonasdan added the State: Pending Release This issue has been resolved in the dev branch and is waiting on a new release label Dec 20, 2023
Eonasdan added a commit that referenced this issue Dec 21, 2023
@Eonasdan Eonasdan mentioned this issue Dec 21, 2023
Eonasdan added a commit that referenced this issue Dec 21, 2023
* fixes #2884

* fixes #2886

* fixes #2881

* fixes #2879

* fixes #2857

* #2793

* #2793
v6.9.4
@Eonasdan
Copy link
Owner

This is fixed in 6.9.4

@Eonasdan Eonasdan removed the State: Pending Release This issue has been resolved in the dev branch and is waiting on a new release label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants