Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of css variables for theming #2857

Closed
2 tasks done
AgentSmith0 opened this issue Sep 4, 2023 · 3 comments
Closed
2 tasks done

Usage of css variables for theming #2857

AgentSmith0 opened this issue Sep 4, 2023 · 3 comments
Labels
Type: Feature Request

Comments

@AgentSmith0
Copy link

Prerequisites

Proposal

What about replacing hard coded css values by css variables.

Motivation and context

This would make theming much easier (light/dark mode and using css variables from other css design frameworks).
@AgentSmith0 AgentSmith0 added State: Triage Tickets that need to be triaged. Type: Feature Request labels Sep 4, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Tempus Dominus Sep 4, 2023
@Eonasdan Eonasdan removed the State: Triage Tickets that need to be triaged. label Sep 28, 2023
@Eonasdan Eonasdan moved this from 🆕 New to 🏗 In progress in Tempus Dominus Dec 19, 2023
@Eonasdan Eonasdan added the State: Pending Release This issue has been resolved in the dev branch and is waiting on a new release label Dec 20, 2023
Eonasdan added a commit that referenced this issue Dec 21, 2023
@Eonasdan
fixes #2857
408f7c6
@Eonasdan Eonasdan mentioned this issue Dec 21, 2023
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Tempus Dominus Dec 21, 2023
@Eonasdan
Copy link
Owner

This is done in v6.9.4

@Eonasdan Eonasdan removed the State: Pending Release This issue has been resolved in the dev branch and is waiting on a new release label Dec 21, 2023
@AgentSmith0
Copy link
Author

It works very well, thank you very much!

@AgentSmith0
Copy link
Author

@Eonasdan But wouldn't it make sense to change the variable scope from :root to something like .tempus-dominus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature Request
Projects
Tempus Dominus
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Eonasdan @AgentSmith0