Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit max height of dropdown selection #358

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Limit max height of dropdown selection #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6ddf02
add max-height
SebastienGllmt Mar 19, 2019
8c975f8
workaround for polymorph bug
SebastienGllmt Mar 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/themes/overrides/OptionsOverrides.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,11 @@
// Css module overrides go here …

.ul {
overflow-x: hidden;
overflow-y: overlay;
max-height: 300px;
&::-webkit-scrollbar-button {
height: 7px;
display: block;
}
}
2 changes: 1 addition & 1 deletion features/step_definitions/select-language-steps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ When(/^I open language selection dropdown$/, async function () {
});

When(/^I select Japanese language$/, async function () {
return this.click('//*[@class="SimpleOptions_label"][contains(text(), "日本語")]', By.xpath);
return this.click('//span[contains(text(), "日本語")]', By.xpath);
});

When(/^I submit the language selection form$/, async function () {
Expand Down