Limit max height of dropdown selection #358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users with small screens were unable to select their language because the dropdown menu was getting cutoff
Solution
To fix this, I made that dropdown selections now have a scrollbar if the size of all items goes over 300px (300 was chosen because we have dropdowns approximately this size before and nobody ever complained until we got over 300)
Here is how it looks like
Over 300px
Under 300px
Note: scrollbar doesn't even appear when under 300px (as expected)