Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit max height of dropdown selection #358

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Conversation

SebastienGllmt
Copy link
Contributor

Problem

Users with small screens were unable to select their language because the dropdown menu was getting cutoff

image

Solution

To fix this, I made that dropdown selections now have a scrollbar if the size of all items goes over 300px (300 was chosen because we have dropdowns approximately this size before and nobody ever complained until we got over 300)

Here is how it looks like

Over 300px

image

Under 300px

Note: scrollbar doesn't even appear when under 300px (as expected)
image

@SebastienGllmt SebastienGllmt added bug (confirmed) Bug with repro steps or logs UI/UX Makes a visual change fix for next version This issue will be taken care of asap labels Mar 19, 2019
@DominikGuzei
Copy link

@SebastienGllmt thanks for the PR, is there any chance to fix this issue properly (= taking the screen into account and ensure that the dropdown never gets cut-off?)

@SebastienGllmt
Copy link
Contributor Author

@DominikGuzei I don't think this is doable in any reasonable way purely in CSS inside the override. If you want to do that kind of logic, you'd probably have to do it inside the javascript of React-Polymorph. I'm happy with a hardcoded 300px for Yoroi but if you want to spend more time on this to have a proper fix for Daedalus, you're welcome to do so.

@nicarq nicarq merged commit 63913a5 into develop Mar 25, 2019
@nicarq nicarq deleted the fix/longOptionSelect branch March 25, 2019 02:34
@DominikGuzei
Copy link

@SebastienGllmt yeah that's what i meant 😉 but no worries, we can take that task over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug (confirmed) Bug with repro steps or logs fix for next version This issue will be taken care of asap UI/UX Makes a visual change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants