Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger Integration #298

Merged
merged 65 commits into from
Mar 13, 2019
Merged

Ledger Integration #298

merged 65 commits into from
Mar 13, 2019

Conversation

SebastienGllmt
Copy link
Contributor

Add ledger support

(very much a WIP. Just creating the PR so we can all track it)

@SebastienGllmt SebastienGllmt force-pushed the feature/ledger-integration branch from 5864e29 to bef1508 Compare February 17, 2019 22:57
@shinsuny shinsuny mentioned this pull request Feb 18, 2019
Closed
15 tasks
nicarq
nicarq reviewed Feb 18, 2019
View reviewed changes
app/api/ada/index.js Outdated Show resolved Hide resolved
nicarq
nicarq reviewed Feb 18, 2019
View reviewed changes
app/api/common.js Outdated Show resolved Hide resolved
@shinsuny shinsuny mentioned this pull request Feb 19, 2019
Closed
6 tasks
nicarq
nicarq reviewed Feb 19, 2019
View reviewed changes
app/domain/SignTx.js Outdated Show resolved Hide resolved
nicarq
nicarq reviewed Feb 19, 2019
View reviewed changes
app/config.js Outdated Show resolved Hide resolved
nicarq
nicarq reviewed Feb 19, 2019
View reviewed changes
app/api/ada/index.js Outdated Show resolved Hide resolved
nicarq
nicarq reviewed Feb 19, 2019
View reviewed changes
app/api/ada/index.js Outdated Show resolved Hide resolved
@shinsuny shinsuny mentioned this pull request Feb 24, 2019
Closed
@shinsuny shinsuny added spec-implementation Its has been approved by the triage process after a proposal was made WIP / DO NOT MERGE Shows that a PR shouldn't be merge labels Feb 24, 2019
shinsuny
shinsuny reviewed Mar 4, 2019
View reviewed changes
.eslintignore Outdated Show resolved Hide resolved
SebastienGllmt
SebastienGllmt commented Mar 10, 2019
View reviewed changes
app/api/ada/hardwareWallet/newTransaction.js Outdated Show resolved Hide resolved
app/api/ada/hardwareWallet/newTransaction.js Outdated Show resolved Hide resolved
app/api/ada/hardwareWallet/newTransaction.js
txExt: UnsignedTransactionExt,
changeAdaAddr: AdaAddress
): string {
// TODO: add type to unsignedTx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

app/components/wallet/hwConnect/ledger/AboutDialog.js Outdated Show resolved Hide resolved
app/components/topbar/TopBarCategory.scss Show resolved Hide resolved
app/stores/ada/LedgerSendStore.js Outdated Show resolved Hide resolved
app/stores/ada/LedgerSendStore.js Outdated Show resolved Hide resolved
app/stores/ada/LedgerSendStore.js Outdated Show resolved Hide resolved
app/stores/ada/TrezorConnectStore.js Show resolved Hide resolved
app/stores/ada/TrezorConnectStore.js Show resolved Hide resolved
@nicarq nicarq marked this pull request as ready for review March 12, 2019 00:47
@shinsuny shinsuny force-pushed the feature/ledger-integration branch from fc1849a to 6c17fe0 Compare March 12, 2019 07:30
@shinsuny shinsuny removed the WIP / DO NOT MERGE Shows that a PR shouldn't be merge label Mar 12, 2019
@SebastienGllmt SebastienGllmt merged commit c45c32c into develop Mar 13, 2019
@nicarq nicarq mentioned this pull request Mar 16, 2019
Merged
@shinsuny shinsuny deleted the feature/ledger-integration branch March 26, 2019 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinsuny shinsuny shinsuny left review comments

@nicarq nicarq nicarq left review comments

@vsubhuman vsubhuman vsubhuman approved these changes

Assignees

@nicarq nicarq

@SebastienGllmt SebastienGllmt

@shinsuny shinsuny

Labels
spec-implementation Its has been approved by the triage process after a proposal was made
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SebastienGllmt @nicarq @vsubhuman @shinsuny