Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spec] Ledger Integration #281

Merged
merged 5 commits into from
Mar 13, 2019
Merged

[spec] Ledger Integration #281

merged 5 commits into from
Mar 13, 2019

Conversation

shinsuny
Copy link
Contributor

@shinsuny shinsuny commented Feb 6, 2019 •
edited
Loading

Proposal for Ledger Integration.

@shinsuny shinsuny added the spec Feature proposal for triage. Required for non-trivial features. label Feb 6, 2019
@shinsuny shinsuny self-assigned this Feb 6, 2019
@shinsuny shinsuny requested a review from vsubhuman February 6, 2019 13:53
@shinsuny shinsuny added the WIP / DO NOT MERGE Shows that a PR shouldn't be merge label Feb 6, 2019
@shinsuny shinsuny force-pushed the docs/hardware-wallet branch 3 times, most recently from 19839d4 to fdfcb99 Compare February 8, 2019 08:03
@shinsuny shinsuny force-pushed the docs/hardware-wallet branch from fdfcb99 to dcec33a Compare February 12, 2019 12:33
nicarq
nicarq reviewed Feb 15, 2019
View reviewed changes
docs/specs/code/ledger-integration/FRIMWARE_UPDATE.md Outdated
@@ -0,0 +1,59 @@
#### Install python-dev (python 2.7) and pip<br/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo in the file name

@shinsuny shinsuny mentioned this pull request Feb 18, 2019
Closed
15 tasks
@shinsuny shinsuny added spec-implementation Its has been approved by the triage process after a proposal was made and removed spec Feature proposal for triage. Required for non-trivial features. labels Feb 18, 2019
@shinsuny shinsuny mentioned this pull request Feb 19, 2019
Closed
6 tasks
@shinsuny shinsuny changed the title [spec] trezor(moved from wiki) and ledger integration [spec] Ledger Integration Mar 7, 2019
@shinsuny shinsuny force-pushed the feature/ledger-integration branch from fc1849a to 6c17fe0 Compare March 12, 2019 07:30
@SebastienGllmt SebastienGllmt removed the WIP / DO NOT MERGE Shows that a PR shouldn't be merge label Mar 13, 2019
@SebastienGllmt SebastienGllmt merged commit ca63ba6 into feature/ledger-integration Mar 13, 2019
@SebastienGllmt SebastienGllmt deleted the docs/hardware-wallet branch March 13, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicarq nicarq nicarq left review comments

@SebastienGllmt SebastienGllmt SebastienGllmt approved these changes

@vsubhuman vsubhuman Awaiting requested review from vsubhuman

Assignees

@shinsuny shinsuny

Labels
spec-implementation Its has been approved by the triage process after a proposal was made
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shinsuny @nicarq @SebastienGllmt