Show fee & Intrawallet transactions #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienGllmt
added
bug (confirmed)
nicarq
reviewed
Jan 18, 2019
| amount: BigNumber, | ||
| fee: BigNumber | ||
| }> { | ||
| // Note: logic taken from the mobile version of Yoroi |
There was a problem hiding this comment.
maybe it could be helpful to have more info from which file
nicarq
reviewed
Jan 18, 2019
| @@ -224,6 +252,10 @@ export default class Transaction extends Component<Props, State> { | |||
| </div> | |||
| )} | |||
| <div> | |||
| <h2> | |||
| Fee: | |||
There was a problem hiding this comment.
it’s a really small detail but I would hide the : to be consistent with the other ones
|
LGTM! |
nicarq
approved these changes
Jan 18, 2019
nicarq
added a commit
that referenced
this pull request
Jan 20, 2019
Show fee & Intrawallet transactions New translations en-US.json (Russian) New translations en-US.json (Korean) New translations en-US.json (Chinese Simplified) New translations en-US.json (Japanese) New translations en-US.json (Korean) New translations en-US.json (Russian) New translations en-US.json (Chinese Simplified) New translations en-US.json (Chinese Traditional) New translations en-US.json (Russian) New translations en-US.json (Japanese) New translations en-US.json (Korean) New translations en-US.json (Chinese Simplified) New translations en-US.json (Chinese Traditional) New translations en-US.json (Japanese) New translations en-US.json (French) New translations en-US.json (Japanese) New translations en-US.json (Korean) New translations en-US.json (Russian) New translations en-US.json (Chinese Simplified) New translations en-US.json (Chinese Traditional) New translations en-US.json (French)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #64