Lots of updates 1.2.0 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicarq
commented
Jan 27, 2019
nicarq
commented
- Fix onClick in TrezorSendConfirmationDialog Fix onClick in TrezorSendConfirmationDialog #246
- Fix missing color fix missing color #243
- Fix onClick in WalletSendConfirmationDialog Fix onClick in WalletSendConfirmationDialog #242
- Show fee & Intrawallet transactions Show fee & Intrawallet transactions #241
- Log time even on empty logs log time even on empty logs #233
- Fix vulnerability in reactdom 16.0.0 Fix vulnerability in reactdom 16.0.0 #232
- Remove unused exports remove unused exports #231
- Change casing on warning label Change casing on warning label #230
- Fix password validation fix password validation #228
- Export transaction to file Export transaction to file [ITERATION 1] #222
- New Crowdin translations New Crowdin translations #252
added default wallet type to CWTWeb if given type is undefined
ID calculation for newly sent transactions
… diagram for basic use cases(create new wallet, send funds)
[doc update] app/i18n
* change password restrictions * fixed tests * fixed more tests
upgrade to react 16 and react-router v4
Babel 7 + Latest Flow + Other necessary dependencies
remove unused exports
fix password validation
log time even on empty logs
Change casing on warning label
To upgrade to the latest version of `react-polymorph` (v8) we need to do two upgrades: - [x] upgrade to v7.2 (based on [this PR](input-output-hk/daedalus#950)) - [x] upgrade to v8 (based on [this PR](input-output-hk/daedalus#1139)) I made both upgrades as the two commits to this PR and it's probably easier to read if you code review the two commits individually (since the changes are orthogonal). I also have a README change that explains what `react-polymorph` v8 does but you can find something similar in the Daedalus PR I linked above. v8 also introduces large refactoring changes that makes a mess of the whole thing. I tried my best to make all the UI look the same while keeping the improvements from v8 but one thing I couldn't stop is that the font size is not 1px bigger across the app (which honestly is not a big deal so I didn't bother). There are probably small things that changed here in there but I manually compared the whole UI and everything looked close enough I don't think anybody would notice any difference that did occur.
### WIP points - [x] fix UI bug in React-polymorph - [ ] add release steps in the repo README - [x] make CI run in parallel for Firefox ### Notably changes 1) Source maps tend to fail on Firefox so your console will be filled with warnings such as ``` Source map error: TypeError: NetworkError when attempting to fetch resource. Resource URL: moz-extension://930fbb33-10a2-403b-b57c-56df447157dd/js/yoroi.bundle.js Source Map URL: NumericInput.js.map ``` This also causes error messages not to render properly in the logs (i.e. stack traces will look something like0 ``` ExtendableError@moz-extension://380304b4-a7df-49e9-b7b8-7b207f40792f/js/vendor.js:174903:14\nLocalizableError@moz-extension://380304b4-a7df-49e9-b7b8-7b207f40792f/js/yoroi.bundle.js:569:65\nNoInputsError@moz-extension://380304b4-a7df-49e9-b7b8-7b207f40792f/js/yoroi.bundle.js:2551:60\n_callee$@moz-extension://380304b4-a7df-49e9-b7b8-7b207f40792f/js/yoroi.bundle.js:34270:19\ntryCatch@moz-extension://380304b4-a7df-49e9-b7b8-7b207f40792f/js/yoroi.bundle.js:42539:37\ninvoke@moz-extension://380304b4-a7df-49e9-b7b8-7b207f40792f/js/yoroi.bundle.js:42792:22\ndefineIteratorMethods/</prototype[method]@moz-extension://380304b4-a7df-49e9-b7b8-7b207f40792f/js/yoroi.bundle.js:42572:16\nstep@moz-extension://380304b4-a7df-49e9-b7b8-7b207f40792f/js/yoroi.bundle.js:904:30\nstep/<@moz-extension://380304b4-a7df-49e9-b7b8-7b207f40792f/js/yoroi.bundle.js:915:13\n ``` You read why, see: webpack/webpack#1194 (comment) https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Use_a_source_map 1) Need to add icons in the manifest to `default_icon` key (Firefox loads from here instead of the `icons` key in Chrome) 1) Need to add addon ID for firefox inside the manifest (I describe why we need to do this and why this requires a custom version of Selenium in the code) 1) Unlike Chrome, Firefox addons get a different URL either every session or every install (deliberately done to avoid fingerprinting) I described how we tackle this inside the unittest framework 1) Need to rename `zip` file to `xpi` to install 1) Need to set `xpinstall.signatures.required` in `about:config` to be able to add unsigned build locally (in non-temporary mode) This is a hack though. To conform to the spec, you must either use the developer edition or use a signed extension. 1) Firefox does not support 'http://127.0.0.1' or 'http://localhost' as script Fortunately this is not used for mainnet and the unittests bypass this restriction (but it will fail for development) 1) Two Firefox-specific CSS bugs (details commented inside the code)
Fix onClick in WalletSendConfirmationDialog
Show fee & Intrawallet transactions
Show fee & Intrawallet transactions New translations en-US.json (Russian) New translations en-US.json (Korean) New translations en-US.json (Chinese Simplified) New translations en-US.json (Japanese) New translations en-US.json (Korean) New translations en-US.json (Russian) New translations en-US.json (Chinese Simplified) New translations en-US.json (Chinese Traditional) New translations en-US.json (Russian) New translations en-US.json (Japanese) New translations en-US.json (Korean) New translations en-US.json (Chinese Simplified) New translations en-US.json (Chinese Traditional) New translations en-US.json (Japanese) New translations en-US.json (French) New translations en-US.json (Japanese) New translations en-US.json (Korean) New translations en-US.json (Russian) New translations en-US.json (Chinese Simplified) New translations en-US.json (Chinese Traditional) New translations en-US.json (French)
New Crowdin translations
Export transaction to file [ITERATION 1]
New Crowdin translations
Added basic UML diagrams
New Crowdin translations
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.