Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change password restrictions #219

Merged
merged 3 commits into from
Jan 13, 2019
Merged

change password restrictions #219

merged 3 commits into from
Jan 13, 2019

Conversation

SebastienGllmt
Copy link
Contributor

Fix #180

@SebastienGllmt SebastienGllmt added UI/UX Makes a visual change small-scale change Changes that are not NFC but small enough in scope that they don't need to go through triage labels Jan 9, 2019
vsubhuman
vsubhuman reviewed Jan 9, 2019
View reviewed changes
app/utils/validations.js
const passwordRegex = /^(?=.*\d)(?=.*[a-z])(?=.*[A-Z]).{7,}$/;
return passwordRegex.test(walletPassword);
// https://xkcd.com/936/
return walletPassword.length >= 12;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be 12 spaces?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be 12 spaces?

Yes. Discussed with @nicarq and @SebastienGllmt - we don't care.

@SebastienGllmt SebastienGllmt merged commit 2e217cb into develop Jan 13, 2019
@SebastienGllmt SebastienGllmt deleted the feature/staplebattery branch January 13, 2019 23:14
@SebastienGllmt SebastienGllmt mentioned this pull request Jan 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsubhuman vsubhuman vsubhuman approved these changes

@nicarq nicarq nicarq approved these changes

Assignees
No one assigned
Labels
small-scale change Changes that are not NFC but small enough in scope that they don't need to go through triage UI/UX Makes a visual change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastienGllmt @nicarq @vsubhuman