Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix password validation #228

Merged
merged 1 commit into from
Jan 14, 2019
Merged

fix password validation #228

merged 1 commit into from
Jan 14, 2019

Conversation

SebastienGllmt
Copy link
Contributor

Premise

  1. In my PR for change password restrictions #219 I changed the validation rules for passwords which includes a more-strict length requirement.
  2. When changing a wallet password, the field "current password" is checked using the password validation rules.

Therefore if your password was valid under the old rules but is no longer valid now, you can no longer change your password.

@SebastienGllmt SebastienGllmt added bug (confirmed) Bug with repro steps or logs fix for next version This issue will be taken care of asap regression bug which was not there in previous versions labels Jan 14, 2019
@nicarq nicarq merged commit dd8a047 into develop Jan 14, 2019
@nicarq nicarq deleted the fix/passwordValidation branch January 14, 2019 23:07
@nicarq nicarq mentioned this pull request Jan 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicarq nicarq nicarq approved these changes

Assignees
No one assigned
Labels
bug (confirmed) Bug with repro steps or logs fix for next version This issue will be taken care of asap regression bug which was not there in previous versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastienGllmt @nicarq