Trezor wallet Catalyst voting registration support #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #8805: Make Ledger wallet Catalyst registration work at API level. |
vsubhuman
requested changes
May 12, 2021
yushih
force-pushed
the
yushi/catalyst-trezor
branch
from
bdc0b8a to
30d86c5
Compare
yushih
force-pushed
the
yushi/catalyst-trezor
branch
from
30d86c5 to
2d65bd0
Compare
vsubhuman
approved these changes
May 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ch8805]
Only the API level work. UI will be updated later.
Summary of changes:
VotingStore.js:When the "PIN confirmation" step is submitted, if it is Trezor wallet, just call
createTransactionaction and skip the next step (asking for spending password)._createTransaction: For hardware wallets, do not callgenerateRegistrationto generate the tx metadata, because the metadata is generated by the wallet. However, we do need to pass the public voting key down (instead of the generated metadata).api/ada/transactions/shelley/HaskellShelleyTxSignRequest.jsandapi/ada/index.jscreateVotingRegTx:Pass the public voting key and nonce down instead of the generated metadata.api/ada/transactions/shelley/trezorTx.jsIf it is a catalyst voting registration tx, construct the
auxiliaryDataof the signing request using the public voting key and nonce passed down.