-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import cosmos-sdk coin types #1
Conversation
Thoughts on this @sahith-narahari @sgerogia @DeshErBojhaa? |
So we're forking the coins type of sdk and maintaining it here in utils? |
I wouldn't call it a full-blown fork, rather we're "importing" those types in our codebase. We're not planning to modify them in any meaningful way, just keep them here to avoid linking the whole SDK for simple Coin parsing. |
Hi, if the code does not change, then I think it's a viable approach.
|
Highly unlikely, considering
Not sure I got your question. |
I don't think each repo needs it's own utils, they'll be very similar so it makes more sense to have one utils. Hope I got your question right |
@sahith-narahari answered it. :) |
This PR imports
Coin
,DecCoin
and their slice versions into this repository so we can use the code with no dependency on Cosmos SDK, so we can drop most of the SDK dependencies when coin parsing is needed.