-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/buffer head #378
Feature/buffer head #378
Conversation
4f2a982
to
f7596f9
Compare
@amgross @MichalPrincNXP First non tested version for serializing and deserializing header data in MessageBuffer. What do you think? I will try to think if we can simplify things, but there is many scenario we need count with |
Hmm tests are not passing, need to see where i have an issue. |
f7596f9
to
b3cf59f
Compare
It looks like i will need to do more massive changes (replacing * with &). But test should pass now. |
b3cf59f
to
ce1e994
Compare
Almost ready. Now i want transform tty driver to be part of framed transport and improve frametransport to be able to receive message at one message. |
ce1e994
to
913e9d7
Compare
@MichalPrincNXP Could you start with reviewing? As tests are passing most transport should work. What could be an issue are RPMSG related transports. I will try rpmsg tty implemenattion, but it would be great if you can some other rpmsg implementation on your side. |
0df0a3b
to
fcac1c4
Compare
@MichalPrincNXP I provided simple fix for rpmsg tty. Tested on board. What i cannot test is MU and other RPMSG transports. Could you try at least some of them (e.g. MU). It would be great if we can confirm at least compilation for all of them and running test for at least one of them (e.g. MU) |
Signed-off-by: Cervenka Dusan <[email protected]>
!!! removed one mbf file and one file renamed. Signed-off-by: Cervenka Dusan <[email protected]>
29e8e29
to
a8cdd62
Compare
Signed-off-by: Cervenka Dusan <[email protected]>
a8cdd62
to
db2aa87
Compare
Hi @MichalPrincNXP , as promissed PR rebased to the top... |
Signed-off-by: Cervenka Dusan <[email protected]>
Signed-off-by: Cervenka Dusan <[email protected]>
e27a424
to
1b6c2ef
Compare
Signed-off-by: Cervenka Dusan <[email protected]>
Signed-off-by: Cervenka Dusan <[email protected]>
thank you, Dusan |
Pull request
Choose Correct
Describe the pull request
Thanks to this PR framed transport should be able to store header data in message buffer and all data can be send to other side at once. So far not tested.
!!!!! Please review and merge this PR: #373
To Reproduce
Expected behavior
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context