Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Read and write the message just by message buffer memory space #284

Closed
2 tasks done
amgross opened this issue Jun 6, 2022 · 3 comments · Fixed by #373 or #378
Closed
2 tasks done

[FEATURE] Read and write the message just by message buffer memory space #284

amgross opened this issue Jun 6, 2022 · 3 comments · Fixed by #373 or #378
Assignees
Milestone

Comments

@amgross
Copy link
Contributor

amgross commented Jun 6, 2022

Is your feature request related to a problem? Please describe.

Currently there is difference between the message header and the message body, while the message header is read/write from the stack:

retVal = underlyingReceive((uint8_t *)&h, sizeof(h));

ret = underlyingSend((uint8_t *)&h, sizeof(h));

the problems with it are:

  1. the send happens in two chunks, which is slower
  2. In devices that there is difference between memory regions, it may make life harder

Describe the solution you'd like

for read:
read first 4 bytes to the message buffer, (and with the curser read from the buffer?)
for write:
In the autogenerated code, after reset the cursor, do dummy write of 4 bytes with the cursor. In FramedTransport::send write to the first 4 bytes the header (if want with the cursor, need to fix first #283 ) and send the whole message in one chunk
Describe alternatives you've considered

can do just the write to the buffer in the way I described.
Steps you didn't forgot to do

  • I checked if there is no related issue opened/closed.
  • I checked that there doesn't exist opened PR which is solving this issue.

Additional context

@Hadatko
Copy link
Member

Hadatko commented Jul 12, 2022

This may impact negativelly (forbidden bytes in buffer) transports which doesn't use framedtransport features.

@amgross
Copy link
Contributor Author

amgross commented Sep 19, 2023

The PR not really solved this issue. @Hadatko \ @MichalPrincNXP can you please re-open it?

@Hadatko Hadatko reopened this Sep 19, 2023
@Hadatko Hadatko linked a pull request Sep 19, 2023 that will close this issue
7 tasks
@Hadatko
Copy link
Member

Hadatko commented Sep 19, 2023

@MichalPrincNXP this is not yet solved. RPMSG tty is not solving this issue. Myabe it was closed automatically so i reopened it.

@Hadatko Hadatko added this to the 1.12.0 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants