Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust-toolchain to nightly-2021-04-25 #605

Merged
merged 6 commits into from
Apr 28, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions crates/rustc_codegen_spirv/src/builder/builder_methods.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1142,10 +1142,6 @@ impl<'a, 'tcx> BuilderMethods<'a, 'tcx> for Builder<'a, 'tcx> {
None
}

fn fptosui_may_trap(&self, _val: Self::Value, _dest_ty: Self::Type) -> bool {
false
}

fn fptoui(&mut self, val: Self::Value, dest_ty: Self::Type) -> Self::Value {
if val.ty == dest_ty {
val
Expand Down
4 changes: 0 additions & 4 deletions crates/rustc_codegen_spirv/src/builder/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -217,10 +217,6 @@ impl<'a, 'tcx> Deref for Builder<'a, 'tcx> {
}

impl<'a, 'tcx> CoverageInfoBuilderMethods<'tcx> for Builder<'a, 'tcx> {
fn create_pgo_func_name_var(&self, _instance: Instance<'tcx>) -> Self::Value {
todo!()
}

fn set_function_source_hash(&mut self, _: rustc_middle::ty::Instance<'tcx>, _: u64) -> bool {
todo!()
}
Expand Down
10 changes: 8 additions & 2 deletions crates/rustc_codegen_spirv/src/codegen_cx/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use rustc_middle::mir::Body;
use rustc_middle::ty::layout::{HasParamEnv, HasTyCtxt};
use rustc_middle::ty::{Instance, ParamEnv, PolyExistentialTraitRef, Ty, TyCtxt, TyS};
use rustc_session::Session;
use rustc_span::def_id::LOCAL_CRATE;
use rustc_span::def_id::{DefId, LOCAL_CRATE};
use rustc_span::symbol::{sym, Symbol};
use rustc_span::{SourceFile, Span, DUMMY_SP};
use rustc_target::abi::call::FnAbi;
Expand Down Expand Up @@ -425,10 +425,16 @@ impl<'tcx> DebugInfoMethods<'tcx> for CodegenCx<'tcx> {
}
}

impl<'tcx> CoverageInfoMethods for CodegenCx<'tcx> {
impl<'tcx> CoverageInfoMethods<'tcx> for CodegenCx<'tcx> {
fn coverageinfo_finalize(&self) {
todo!()
}
fn get_pgo_func_name_var(&self, _: Instance<'tcx>) -> SpirvValue {
todo!()
}
fn define_unused_fn(&self, _: DefId) {
todo!()
}
}

impl<'tcx> AsmMethods for CodegenCx<'tcx> {
Expand Down
2 changes: 1 addition & 1 deletion crates/rustc_codegen_spirv/src/decorations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ impl SerializedSpan {

// Sanity check - assuming `SerializedSpan` isn't corrupted, this assert
// could only ever fail because of a hash collision.
assert!(self.lo <= self.hi && self.hi <= file.byte_length());
assert!(self.lo <= self.hi && self.hi <= (file.end_pos.0 - file.start_pos.0));

Some(Span::with_root_ctxt(
file.start_pos + Pos::from_u32(self.lo),
Expand Down
18 changes: 10 additions & 8 deletions crates/rustc_codegen_spirv/src/spirv_type.rs
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,11 @@ impl SpirvType {
}
8 | 16 | 32 | 64 => (),
128 => cx.zombie_with_span(result, def_span, "u128"),
other => cx
.tcx
.sess
.fatal(&format!("Integer width {} invalid for spir-v", other)),
other => cx.zombie_with_span(
result,
def_span,
&format!("Integer width {} invalid for spir-v", other),
),
};
result
}
Expand All @@ -130,10 +131,11 @@ impl SpirvType {
cx.zombie_with_span(result, def_span, "f64 without OpCapability Float64")
}
32 | 64 => (),
other => cx
.tcx
.sess
.fatal(&format!("Float width {} invalid for spir-v", other)),
other => cx.zombie_with_span(
result,
def_span,
&format!("Float width {} invalid for spir-v", other),
),
};
result
}
Expand Down
Loading