Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder now always builds with nightly #345

Closed
wants to merge 1 commit into from
Closed

Conversation

VZout
Copy link
Member

@VZout VZout commented Dec 14, 2020

This allows a lot more flexibility in using the builder in stable repositories.
Note that it doesn't install components.

Copy link
Contributor

@khyperia khyperia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do go this route, could we add a test to make sure rust-toolchain and this string match? I can absolutely see this accidentally getting out of date.

For example, extract this string to a const, and write a test to make sure rust-toolchain contains the string.

@eddyb
Copy link
Contributor

eddyb commented Dec 14, 2020

You can use include_str! + parsing the toml in a (spirv-builder/build.rs) build script, to compute the value, let Cargo record it, and then env!(...) to read it in spirv-builder/src/lib.rs (assuming we don't want to parse the TOML at runtime, but maybe a simple toolchain = " string search would work?).

But also we could bundle the rust-toolchain with the spirv-builder and drop it in the target directory, or in some temporary directory elsewhere, and use that directory as the working dir for the nested Cargo invocation.

@VZout
Copy link
Member Author

VZout commented Dec 14, 2020

Depends on #239

@VZout VZout closed this Dec 14, 2020
@XAMPPRocky XAMPPRocky deleted the builder_nightly branch April 30, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants