Skip to content

Commit

Permalink
Cleanup pass on example shader and vk example-runner (#109)
Browse files Browse the repository at this point in the history
* get rid of vertex buffers in example

* get rid of unused attributes in example shader

* use negative viewport height to match wgpu

* remove depth buffer

* use SRGB surface

* improve tonemapping

remove 'gamma correction' in favor of hardware srgb support

* make clippy happy

* move tonemapping out of sky(), rename gl_pos to builtin_pos

* rename shaders and use sky shader in wgpu example runner

* apply srgb OETF and invert clip space for cpu example runner

* restructure example directory structure according to #170

* update winit in wgpu example runner

* fix deny.toml example crate refs

* fix ci example name on maOS

* example-shader -> sky-shader in docs

* update sky shader image

* re-enable clippy and make it happy
  • Loading branch information
fu5ha authored Oct 30, 2020
1 parent 5a7aabe commit b12a2f3
Show file tree
Hide file tree
Showing 21 changed files with 281 additions and 826 deletions.
12 changes: 5 additions & 7 deletions .github/workflows/clippy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,9 @@ clippy spirv-builder

# Examples

# disabled due to https://github.com/EmbarkStudios/rust-gpu/issues/186
#clippy examples/example-runner
clippy examples/runners/ash
clippy examples/runners/wgpu

clippy examples/wgpu-example-runner

clippy_no_features examples/example-runner-cpu
clippy_no_features examples/example-shader
clippy_no_features examples/wgpu-example-shader
clippy_no_features examples/runners/cpu
clippy_no_features examples/shaders/sky-shader
clippy_no_features examples/shaders/simplest-shader
10 changes: 5 additions & 5 deletions .github/workflows/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ cargo_test spirv-builder
# Examples
# See: https://github.com/EmbarkStudios/rust-gpu/issues/84
if [[ -z "${CI}" && "$os" != "macOS" ]]; then
cargo_test examples/example-runner
cargo_test examples/runners/ash
fi

cargo_test examples/wgpu-example-runner
cargo_test examples/runners/wgpu

cargo_test_no_features examples/example-runner-cpu
cargo_test_no_features examples/example-shader
cargo_test_no_features examples/wgpu-example-shader
cargo_test_no_features examples/runners/cpu
cargo_test_no_features examples/shaders/sky-shader
cargo_test_no_features examples/shaders/simplest-shader
Loading

0 comments on commit b12a2f3

Please sign in to comment.