Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to egui 0.27 #201

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Mar 28, 2024

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Update for egui 0.27.0

Related Issues

List related issues here

@abey79 abey79 requested review from emilk and TimonPost as code owners March 28, 2024 13:48
@abey79 abey79 changed the title Update for egui 0.27.0 Update for egui 0.27.1 Mar 30, 2024
@TimonPost TimonPost merged commit db01a34 into EmbarkStudios:main Apr 2, 2024
5 of 6 checks passed
@fornwall fornwall mentioned this pull request Apr 5, 2024
fornwall added a commit that referenced this pull request Apr 5, 2024
The changes here are the result of running `cargo vet regenerate
exemptions && cargo vet regenerate imports` and should fix the CI build
failures after #201.
@emilk
Copy link
Collaborator

emilk commented May 17, 2024

This broke selection of scopes in the flame graph, as well as scrolling.

emilk added a commit that referenced this pull request May 17, 2024
@emilk emilk changed the title Update for egui 0.27.1 Update to egui 0.27 May 17, 2024
@emilk emilk mentioned this pull request May 17, 2024
emilk added a commit that referenced this pull request May 17, 2024
emilk added a commit that referenced this pull request May 17, 2024
* Reverts #201
* Closes #205

The update to egui 0.27 broke scrolling and selection of scopes in the
flamegraph.

I'll revert it, and then we don't merge things without testing them next
time.
emilk pushed a commit that referenced this pull request May 17, 2024
### Checklist

* [x] I have read the [Contributor Guide](../CONTRIBUTING.md)
* [x] I have read and agree to the [Code of
Conduct](../CODE_OF_CONDUCT.md)
* [x] I have added a description of my changes and why I'd like them
included in the section below

### Description of Changes

This PR cancels the revert (#208) of egui 0.27.1 update (#201) and fix
the flamegraph interaction bug it introduced whenever the flamegraph's
scroll area was active.

### Related Issues

* Closes #207
* Closes #205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants