Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍳 puffin-egui: Incorrect flamegraph frame selection input handling #205

Closed
tosti007 opened this issue Apr 22, 2024 · 2 comments · Fixed by #208, #211 or #214
Closed

🍳 puffin-egui: Incorrect flamegraph frame selection input handling #205

tosti007 opened this issue Apr 22, 2024 · 2 comments · Fixed by #208, #211 or #214
Labels
bug Something isn't working

Comments

@tosti007
Copy link
Contributor

tosti007 commented Apr 22, 2024 •
edited
Loading

Describe the bug
With prior versions it was possible to select a specific frame within the flamegraph viewer. With the lastest version selecting a specific scope focuses the ScrollArea wrapping the lists of scopes instead. I think this is due to egui v0.27's changes to how input handling is performed.

To Reproduce
Steps to reproduce the behavior:

  1. Run the eframe.rs example.
  2. Open the flamegraph.
  3. Pause the frame collection with space.
  4. Select any of the previous frames.
  5. Notice that this is not possible and scrolling is activated instead.

Expected behavior
I expect to select the frame I clicked on, as was the case with egui v0.26.
@tosti007 tosti007 added the bug Something isn't working label Apr 22, 2024
@tosti007 tosti007 mentioned this issue Apr 22, 2024
Open
20 tasks
@tosti007 tosti007 mentioned this issue May 10, 2024
Closed
3 tasks
@emilk
Copy link
Collaborator

emilk commented May 17, 2024

Broke by #201

@emilk emilk mentioned this issue May 17, 2024
Merged
emilk added a commit that referenced this issue May 17, 2024
@emilk
Revert update to egui 0.27 (#208)
2d7d3c6 
* Reverts #201
* Closes #205

The update to egui 0.27 broke scrolling and selection of scopes in the
flamegraph.

I'll revert it, and then we don't merge things without testing them next
time.
@tosti007 tosti007 mentioned this issue May 17, 2024
Merged
3 tasks
emilk pushed a commit that referenced this issue May 17, 2024
@abey79
Fix broken flamegraph interaction with egui 0.27.1 (#211)
b6fe0a1 
### Checklist

* [x] I have read the [Contributor Guide](../CONTRIBUTING.md)
* [x] I have read and agree to the [Code of
Conduct](../CODE_OF_CONDUCT.md)
* [x] I have added a description of my changes and why I'd like them
included in the section below

### Description of Changes

This PR cancels the revert (#208) of egui 0.27.1 update (#201) and fix
the flamegraph interaction bug it introduced whenever the flamegraph's
scroll area was active.

### Related Issues

* Closes #207
* Closes #205
@tosti007 tosti007 mentioned this issue May 23, 2024
Merged
3 tasks
@tosti007
Copy link
Contributor Author

This was accidentally closed through #211, as I phrased my sentence unclearly. After that PR the issue is still present for me.

@Hoodad Hoodad mentioned this issue Jun 25, 2024
Closed
Hoodad pushed a commit that referenced this issue Jun 28, 2024
@tosti007
🪂 Disable drag_to_scroll on frame selection ScrollArea (#214)
88c8d16 
Redo of #207

### Checklist

* [x] I have read the [Contributor Guide](../CONTRIBUTING.md)
* [x] I have read and agree to the [Code of
Conduct](../CODE_OF_CONDUCT.md)
* [x] I have added a description of my changes and why I'd like them
included in the section below

### Description of Changes
In the version `0.27` release of `egui`, the interaction handling was
changed. This caused the scope selection in the flamegraph to be
unselectable. By disabling the `drag_to_scroll` on the related
`ScrollArea` this issue is solved.

The latest scope selection does not suffer from this, as it does not use
a `ScrollArea`.

Note that this does not have any behavioral effect, but instead results
in the same behavior of click/drag/scroll when on egui `0.26`!

### Related Issues
- Fixes #205

```[tasklist]
### Tested on
- [x] Windows
- [x] Linux
- [x] Mac
- [x] Android
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@emilk @tosti007